Fixed issue #42 - corrected fill inheritance by fixing fill ref #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@mattleibow may you review this PR, please? |
|
@mattleibow can you merge pls |
|
Sorry about the very long delay folks, I have been hard at work getting the next installment of SkiaSharp out and there have been a few setbacks due to big bugs and things like that. Will review now... |
mattleibow
requested changes
Oct 4, 2018
SkiaSharp.Extended.Svg/source/SkiaSharp.Extended.Svg.Shared/SKSvg.cs
Outdated
Show resolved
Hide resolved
Closed
|
Hi, @mattleibow! |
|
Hi, @mattleibow! How is it going with this merge? |
|
I am on it, was travelling and had stacks of meetings. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42 is caused by missing fill cloning for all groups. Thus fill was edited in child elements, causing incorrect inheritance.