Remove code-blocks #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename gen file
cbush
requested changes
May 20, 2022
src/bluehawk/actions/snip.test.ts
Outdated
| "utf8" | ||
| ); | ||
| expect(fileContents).toStrictEqual(`.. code-block:: javascript | ||
| expect(fileContents).toStrictEqual(`.. snippet:: javascript |
There was a problem hiding this comment.
In this case it still needs to be code-block for rST's sake
mongodben
reviewed
May 20, 2022
src/bluehawk/actions/snip.ts
Outdated
| @@ -83,7 +83,7 @@ export const formatInRst = async ( | |||
| ? rstLanguageMap.get(document.extension) | |||
| : "text"; | |||
|
|
|||
| const rstHeader = ".. code-block::"; | |||
| const rstHeader = ".. snippet::"; | |||
There was a problem hiding this comment.
please revert this. not valid RST
mongodben
reviewed
May 20, 2022
src/bluehawk/actions/snip.test.ts
Outdated
| "utf8" | ||
| ); | ||
| expect(rstFileContents).toStrictEqual(`.. code-block:: javascript | ||
| expect(rstFileContents).toStrictEqual(`.. snippet:: javascript |
There was a problem hiding this comment.
mongodben
reviewed
May 20, 2022
src/bluehawk/actions/snip.test.ts
Outdated
| "utf8" | ||
| ); | ||
| expect(fileContents).toStrictEqual(`.. code-block:: javascript | ||
| expect(fileContents).toStrictEqual(`.. snippet:: javascript |
mongodben
reviewed
May 20, 2022
src/bluehawk/actions/snip.test.ts
Outdated
| ), | ||
| "utf8" | ||
| ); | ||
| expect(fileContentsSync).toStrictEqual( | ||
| `.. code-block:: swift | ||
| `.. snippet:: swift |
mongodben
reviewed
May 20, 2022
src/bluehawk/actions/snip.test.ts
Outdated
| ), | ||
| "utf8" | ||
| ); | ||
| // TODO: Expect this not to emphasize lines, since the :emphasize: tag was | ||
| // completely in the other state | ||
| /* | ||
| expect(fileContentsLocal).toStrictEqual( | ||
| `.. code-block:: swift | ||
| `.. snippet:: swift |
cbush
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace code-blocks with snippets (incl. codeblock and Codeblock, too)