Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomx program not showing #190

Open
Gingeropolous opened this issue Sep 27, 2019 · 5 comments
Open

randomx program not showing #190

Gingeropolous opened this issue Sep 27, 2019 · 5 comments

Comments

@Gingeropolous
Copy link
Contributor

I used the randomx branch with the recent monero master.

everything works fine except for the display of the randomx program

https://testnet.xmrchain.net/randomx/1309514

is there a flag or something I'm missing?

@moneroexamples
Copy link
Owner

moneroexamples commented Sep 27, 2019

Will look into.

rx_vm is still null!

issue

@moneroexamples
Copy link
Owner

The issue is that rx_vm in https://github.com/monero-project/monero/blob/master/src/crypto/rx-slow-hash.c#L65 is static now. This make it private variable, thus I could relay on monero's randomx virtual machine like before.

@Gingeropolous
Copy link
Contributor Author

oh well. It would have been cool to see it.

If you want to go through the effort, you could probably re-create the program just using the input values. but that could be a lot of work for this.

@moneroexamples
Copy link
Owner

Yes I started doing it, but then other things needed for creating my own vm also become static, e,g, rx_initdata https://github.com/monero-project/monero/blob/master/src/crypto/rx-slow-hash.c#L65 Basically I think I would have to fork-off rx-slow-hash.c (or copy paste large chanks of it) and keep it as part the explorer. Not sure if doing this is worth maintaining it forever after that.

Still looking into it, so still trying to figure something out.

@moneroexamples
Copy link
Owner

I forked rx-slow-hash.c and made the rx code work again. The changes are in this branch: https://github.com/moneroexamples/onion-monero-blockchain-explorer/tree/fix_randomx_code for now

You can also preview how it works on my testned node, e.g. http://139.162.60.17:8083/randomx/1315380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants