Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packed data in 2019c.json is not the same as latest.json #836

Closed
gilmoreorless opened this issue May 1, 2020 · 1 comment
Closed

Packed data in 2019c.json is not the same as latest.json #836

gilmoreorless opened this issue May 1, 2020 · 1 comment
Labels

Comments

@gilmoreorless
Copy link
Member

While investigating #835 I found a separate problem with the packed data files. In version 0.5.28 the countries data was added, and the 2019c.json and latest.json files were updated to include the data.

However, the data is not consistent between the two files, despite latest.json claiming it's version 2019c.

$ git checkout 0.5.28
$ diff data/packed/2019c.json data/packed/latest.json

Some snippets of the diff (because the full diff is too long to post here):

4,10c4,10
< 		"Africa/Abidjan|LMT GMT|g.8 0|01|-2ldXH.Q|48e5|CI BF GM GN ML MR SH SL SN TG",
< 		"Africa/Accra|LMT GMT +0020|.Q 0 -k|012121212121212121212121212121212121212121212121|-26BbX.8 6tzX.8 MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE|41e5|GH",
< 		"Africa/Nairobi|LMT EAT +0230 +0245|-2r.g -30 -2u -2J|01231|-1F3Cr.g 3Dzr.g okMu MFXJ|47e5|KE DJ ER ET KM MG SO TZ UG YT",
< 		"Africa/Algiers|PMT WET WEST CET CEST|-9.l 0 -10 -10 -20|0121212121212121343431312123431213|-2nco9.l cNb9.l HA0 19A0 1iM0 11c0 1oo0 Wo0 1rc0 QM0 1EM0 UM0 DA0 Imo0 rd0 De0 9Xz0 1fb0 1ap0 16K0 2yo0 mEp0 hwL0 jxA0 11A0 dDd0 17b0 11B0 1cN0 2Dy0 1cN0 1fB0 1cL0|26e5|DZ",
< 		"Africa/Lagos|LMT WAT|-d.A -10|01|-22y0d.A|17e6|NG AO BJ CD CF CG CM GA GQ NE",
< 		"Africa/Bissau|LMT -01 GMT|12.k 10 0|012|-2ldX0 2xoo0|39e4|GW",
< 		"Africa/Maputo|LMT CAT|-2a.k -20|01|-2GJea.k|26e5|MZ BI BW CD MW RW ZM ZW",
---
> 		"Africa/Abidjan|LMT GMT|g.8 0|01|-2ldXH.Q|48e5",
> 		"Africa/Accra|LMT GMT +0020|.Q 0 -k|012121212121212121212121212121212121212121212121|-26BbX.8 6tzX.8 MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE|41e5",
> 		"Africa/Nairobi|LMT EAT +0230 +0245|-2r.g -30 -2u -2J|01231|-1F3Cr.g 3Dzr.g okMu MFXJ|47e5",
> 		"Africa/Algiers|PMT WET WEST CET CEST|-9.l 0 -10 -10 -20|0121212121212121343431312123431213|-2nco9.l cNb9.l HA0 19A0 1iM0 11c0 1oo0 Wo0 1rc0 QM0 1EM0 UM0 DA0 Imo0 rd0 De0 9Xz0 1fb0 1ap0 16K0 2yo0 mEp0 hwL0 jxA0 11A0 dDd0 17b0 11B0 1cN0 2Dy0 1cN0 1fB0 1cL0|26e5",
> 		"Africa/Lagos|LMT WAT|-d.A -10|01|-22y0d.A|17e6",
> 		"Africa/Bissau|LMT -01 GMT|12.k 10 0|012|-2ldX0 2xoo0|39e4",
> 		"Africa/Maputo|LMT CAT|-2a.k -20|01|-2GJea.k|26e5",
623,626c623,626
< 		"BH|Asia/Qatar",
< 		"BI|Africa/Maputo",
< 		"BJ|Africa/Lagos",
< 		"BL|America/Port_of_Spain",
---
> 		"BH|Asia/Qatar Asia/Bahrain",
> 		"BI|Africa/Maputo Africa/Bujumbura",
> 		"BJ|Africa/Lagos Africa/Porto-Novo",
> 		"BL|America/Port_of_Spain America/St_Barthelemy",
@ichernev
Copy link
Contributor

I believe I fixed that in 0.5.36, the data pipeline was messed up, esp around metadata, because the metadata was used but not yet generated, so whatever was latest.js that got picked up (pretty messed up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants