Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release changes from #39 as 0.0.4 #65

Closed
dickfickling opened this issue Mar 3, 2014 · 10 comments
Closed

Release changes from #39 as 0.0.4 #65

dickfickling opened this issue Mar 3, 2014 · 10 comments

Comments

@dickfickling
Copy link

I'm really digging moment-timezone, and the performance enhancement from #39 has made it much faster than any alternatives, but I'd love to be able to use a point release rather than point my project at a specific commit. Would it be possible to merge those changes and release 0.0.4?

Thanks!

@aheckmann
Copy link

+1 A new release would be great!

@icambron
Copy link
Member

icambron commented Mar 8, 2014

AFAIK, this on @mj1856. I can actually make a release, but since I don't actually use moment-timezone, I'm hesitant here. (We also need to update the website to reflect the current version).

@mattjohnsonpint
Copy link
Contributor

@icambron - I've been too swamped to work on this lately. I'd be very grateful if you could please release what is there to at least close on the known issues that have already been fixed.

As it looks like the project is getting more and more popular, I will try to cut some time out in the next week or two to do an end-to-end code review and address the more critical concerns.

Also, some of the bugs reported have to do with the fact that moment-timezone relies on moment, and in-turn relies on Date objects, which have known issues that can't easily be worked around. So while I can try to make things less-broken, I'd be more interested in removing the Date object dependency from moment.

@icambron
Copy link
Member

@mj1856 I'll try to get a release out soon then, though I'm a bit swamped too.

Threadjacking, but I'm not sure how you can remove the Date object from Moment without (clears throat) also having the TZ data there to tell you when the DSTs are. So I think you'd need to make the underlying Date implementation pluggable and then swap it out for moment-timezone.

@aheckmann
Copy link

would love to see a release for now while you hash out the roadmap forward.

@ichernev
Copy link
Contributor

The master branch is messed up at the moment (a few merges were done there instead of develop), related changes in moment are also messed up (check #66). I'll work on fixing the DST bug (requires moment change) and release a working moment-timezone, with DST and perf improvements and everything. Patches welcome as usual.

@visnup
Copy link

visnup commented Mar 27, 2014

also would love to see a point release. ❤️

@jessehouchins
Copy link

Any updates on this?

@icambron
Copy link
Member

@jessehouchins This is released.

@aheckmann
Copy link

\0/ thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants