Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test link in html reporter #5224

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

danny0838
Copy link
Contributor

PR Checklist

Overview

Fix as mentioned in the related issue comment.

Copy link

linux-foundation-easycla bot commented Oct 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dependabot[bot] (708e5f0)
  • ✅ login: JoshuaKGoldberg / name: Josh Goldberg ✨ (473e7d8)
  • ✅ login: danny0838 / name: Danny Lin (6e8bcdf)

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just one style nit, but nothing functionally blocking. 🚀

Will leave open for a bit in case anybody from @mochajs/maintenance-crew wants to take a look.

lib/reporters/html.js Outdated Show resolved Hide resolved
@JoshuaKGoldberg
Copy link
Member

Oh, and - please sign the CLA so we can accept this @danny0838.

@danny0838 danny0838 force-pushed the main branch 2 times, most recently from 6ec2434 to 92af340 Compare October 12, 2024 00:58
dependabot bot and others added 2 commits October 14, 2024 17:11
Bumps the github-actions group with 1 update: [joelwmale/webhook-action](https://github.com/joelwmale/webhook-action).


Updates `joelwmale/webhook-action` from 2.3.2 to 2.4.1
- [Release notes](https://github.com/joelwmale/webhook-action/releases)
- [Commits](joelwmale/webhook-action@2.3.2...2.4.1)

---
updated-dependencies:
- dependency-name: joelwmale/webhook-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
- `grep` may not work as expected if a previous `fgrep` or `invert` parameter exists.
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix test link in html reporter fix: test link in html reporter Oct 19, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit f054acc into mochajs:main Oct 29, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: test links in the browser reporter keep the original fgrep and invert params
2 participants