fix: proper version check in hasStableEsmImplementation

[alexander-fenster]

Fixes #4652.

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• All new code requires tests to ensure against regressions.

Description of the Change

The version check in hasStableEsmImplementation returns true for any version that has minor component >= 22 (e.g. for version 10.24.x which is currently the latest one in the 10.x branch). Even though Node.js v10 is officially not supported, I still see a lot of sense to fix this and make hasStableEsmImplementation work properly.

Alternate Designs

None

Why should this be in core?

A lot of CI tasks are still using 10.x for compatibility reasons.

Benefits

No unintended breaking change to Node.js v10.24.x users.

Possible Drawbacks

None known.

Applicable issues

#4652

[coveralls]

Coverage increased (+0.003%) to 94.396% when pulling b0e6bd6 on alexander-fenster:version-check into 8339c3d on mochajs:master.

[giltayar]

I would strongly recommend using Mocha v8 if you're using Node v10.

But, hey, why not accept this PR? 😊 LGTM.

But please note that accepting this PR should not mean that we support Node v10 in Mocha >= v9, as there may be other incompatibilities that we are not aware of.

[alexander-fenster]

Thank you folks! Re: "using Mocha v8 if you're using Node v10" - We don't really use Node v10 :) We just want to keep it in our CI for just a little longer, and don't want to pay for it by staying on the old version. Sure, if a real breaking change comes, we'll have no choice, but here in this case the trivial fix could make it live longer. So - again - thanks :)