fix test/unit/hook.spec.js #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Function.prototype.name` is not available in IE11, and will cause the browser tests to fail.
boneskull
added
type: chore
|
If you're wondering why this wasn't caught, it's because SauceLabs tests only run for branch commits; not PRs. Browser tests do get run for PRs--but only in headless Chrome. |
Signed-off-by: Christopher Hiller <[email protected]>
Munter
approved these changes
May 14, 2020
|
also: |
craigtaub
pushed a commit
that referenced
this pull request
May 21, 2020
* fix test/unit/hook.spec.js `Function.prototype.name` is not available in IE11, and will cause the browser tests to fail. * another IE11 fix: avoid Array.prototype.findIndex Signed-off-by: Christopher Hiller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function.prototype.nameis not available in IE11, and will cause the browser tests to fail.Ideally, we could catch this with ESLint, but here's hoping we don't need to do that.
cc @nicojs