Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebSockets proxy #14

Open
mmatczuk opened this issue Feb 21, 2017 · 10 comments
Open

Add WebSockets proxy #14

mmatczuk opened this issue Feb 21, 2017 · 10 comments

Comments

@mmatczuk
Copy link
Owner

mmatczuk commented Feb 21, 2017

If you think this is needed vote by adding 👍 thanks!

@mmatczuk mmatczuk added this to the release-1.1 milestone Apr 18, 2017
@mmatczuk mmatczuk removed this from the release-1.1 milestone Nov 17, 2017
@jenskastensson
Copy link

(Y)

@hugows
Copy link

hugows commented Nov 23, 2017

@jenskastensson you have to click the smiley icon on the original comment by mmatczuk

@dyu
Copy link

dyu commented Feb 27, 2018

I just tried this with the tcp protocol and it works. Any foreseeable problems with this approach?
The other project that has native websockets proxy is frp and it works as well from my tests.

@afiz
Copy link

afiz commented Apr 29, 2018

Any idea when the websocket can be supported? I test it just now, still not going through.

Dear dyu, i also tested 'frp', and websocket is working. But is it secured? I don't see any TLS words at its websites

@david81
Copy link

david81 commented Nov 6, 2018

Another vote for WSS support. Would love to use this for remote access to a Home Assistant instance

@AkeemMcLennon
Copy link

@mmatczuk httputil.ReverseProxy was updated in Go 1.12 to support websockets automatically. Theoretically you might be able to close this ticket for free by recompiling against go1.12. See golang/go#26937

I haven't had a chance to test against your project in particular, but I've had success with other code that "just works" after upgrading. I stumbled across both github issues while doing some research, so I thought it might be useful to let you know.

@Grabber
Copy link

Grabber commented Apr 14, 2019

@mmatczuk and @AkeemMcLennon

go version go1.12.4 linux/amd64

2019/04/14 20:33:49 http: proxy error: can't switch protocols using non-Hijacker ResponseWriter type *http2.responseWriter

https://stackoverflow.com/questions/27075478/when-to-use-hijack-in-golang

@Grabber
Copy link

Grabber commented Apr 15, 2019

Over a tcp tunnel, websocket is working with go 1.12.4

@uri
Copy link

uri commented May 29, 2020

Over a tcp tunnel, websocket is working with go 1.12.4

@Grabber can you elaborate on what you did?

@hons82
Copy link

hons82 commented Mar 26, 2021

@mmatczuk and @AkeemMcLennon

go version go1.12.4 linux/amd64

2019/04/14 20:33:49 http: proxy error: can't switch protocols using non-Hijacker ResponseWriter type *http2.responseWriter

https://stackoverflow.com/questions/27075478/when-to-use-hijack-in-golang

I'd still be interested in this feature.... Can anybody out there give me a hint on how that could be implemented? Or point me to a source to "copy"?

fyi #32763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants