Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade click to >=8.0.0,<9.0.0 #287

Closed
aristizabal95 opened this issue Feb 6, 2023 · 7 comments
Closed

Upgrade click to >=8.0.0,<9.0.0 #287

aristizabal95 opened this issue Feb 6, 2023 · 7 comments

Comments

@aristizabal95
Copy link

Both medperf and MLCube depend on click for their CLIs. Medperf is encountering a click issue when running on Windows, as explained by issue fastapi/typer#427

The proposed solution is to install click>=8.0.0,<9.0.0, but mlcube depends on click==7.1.2, causing a ResolutionImpossible error.

Would it be possible to upgrade to the requested versions? Of course, assuming this doesn't break anything on your side.

@sergey-serebryakov
Copy link
Contributor

Working on this today, should be possible.

@sergey-serebryakov
Copy link
Contributor

sergey-serebryakov commented Feb 7, 2023

I updated the click version and MLCube code. MLCube core library has no conflicts. Almost all MLCube runner have no conflicts as well except one - KubeFlow runner. It depends on kfp library that needs click 7.1.2. Looking for advice / possible solutions how to fix this.

@aristizabal95
Copy link
Author

Hmm it's not as clean as expected. I'll see if I can bypass Typer's error another way for Windows. Thanks for the support! Let me know if anything changes on your side

@aristizabal95
Copy link
Author

Downgrading typer to <0.5.0 fixed my issue without requiring changes to other dependencies. This issue can be closed

@sergey-serebryakov
Copy link
Contributor

@aristizabal95 Turns out there's a super simple solution - upgrading kfp version to 1.8.18. I have not tested the Kubeflow runner though (it's not that important at this point in time anyway). So, we can actually upgrade the click version.

@sergey-serebryakov
Copy link
Contributor

Implemented in #297.

@sergey-serebryakov
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants