Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise.done is deprecated. #2

Closed
manicmarvin opened this issue Jan 19, 2017 · 7 comments
Closed

Promise.done is deprecated. #2

manicmarvin opened this issue Jan 19, 2017 · 7 comments

Comments

@manicmarvin
Copy link

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1214:5)
Object.openPane (/Users/marvin/.atom/packages/mjml-preview/lib/mjml-preview.js:73:72)
<unknown> (/Users/marvin/.atom/packages/mjml-preview/lib/mjml-preview.js:41:17)
Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
TextBuffer.saveAs (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:1144:27)
@gnegreiros
Copy link

Same issue.

@JeffCleverley
Copy link

same issue

@pgallar
Copy link

pgallar commented Feb 5, 2017

Same issue

@Atn-D
Copy link

Atn-D commented Feb 8, 2017

Same issue.

@ngarnier
Copy link
Member

Thanks for opening this issue and adding in guys, it should be fixed by updating to the latest version

@benjaminsehl
Copy link

This is popping up again after updating to 2.0.0

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done - <embedded>:1681:9
<unknown> - /Users/homefolder/.atom/packages/mjml-preview/lib/mjml-preview.js:84:12
Object.openPane - /Users/homefolder/.atom/packages/mjml-preview/lib/mjml-preview.js:87:9
<unknown> - /Users/homefolder/.atom/packages/mjml-preview/lib/mjml-preview.js:41:17
Function.module.exports.Emitter.simpleDispatch - <embedded>:66277:20
Emitter.emit - <embedded>:66393:34

Is there something special I should be doing when updating?

@ngarnier
Copy link
Member

hey @benjaminsehl, we reintroduced that in an update of the package, but you can ignore it, it's just a warning (it won't lead to any error). We'll fix it in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants