Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving once closes the preview, saving again opens it again #15

Closed
gdavalos opened this issue Nov 10, 2017 · 6 comments
Closed

Saving once closes the preview, saving again opens it again #15

gdavalos opened this issue Nov 10, 2017 · 6 comments

Comments

@gdavalos
Copy link

This problem began recently so it might be because of some recent atom update.

Steps to reproduce:

  1. Open a mjml file and open the preview
  2. Make some changes and save, this will close the preview
  3. Save again and the preview will open again
@RDumais
Copy link

RDumais commented Nov 20, 2017

I am having the same issue.

@ngarnier
Copy link
Member

ngarnier commented Dec 8, 2017

Hi, thanks for reporting the issue @gdavalos & @RDumais, I could reproduce. I did not notice it initially as I had disabled the auto-preview on save.

Indeed it must be related to an Atom update... we'll have to dig into it.

@eek4ever
Copy link

eek4ever commented Feb 3, 2018

@ngarnier, Hi!
I have the same problem. Please fix it

@ngarnier
Copy link
Member

ngarnier commented Feb 3, 2018

hey @eek4ever, we've got a lot going on with MJML 4 in the pipe. Any help with this issue would be appreciated, feel free to look into it and share anything you find!

@ngarnier
Copy link
Member

This is fixed in the latest version of the package.

@eek4ever
Copy link

eek4ever commented Apr 13, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants