Echo effect is not synchronized with actual tempo

[mixxxbot]

Reported by: uklotzde
Date: 2018-09-18T23:01:12Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1793232
Attachments: [echo out effect.png](https://bugs.launchpad.net/bugs/1793232/+attachment/5190352/+files/echo out effect.png)

---

I usually adjust the time parameter of the echo effect to the 12 o'clock position to get a beat synchronized echo out effect. This doesn't seem to work correctly when pitching the playing track. The synchronization only takes the nominal tempo of the track into account, but not the actual tempo.

Currently the echo effect cannot be used for a beat synchronized echo out on tracks that are not played with their original tempo. This is a very common case when trying to match tracks with different tempos somewhere in the middle between their original tempos. For some tracks this is barely noticeable while others are producing weird double beats when activating the echo effect.

[mixxxbot]

Commented by: uklotzde
Date: 2018-09-18T23:03:50Z
Attachments: [echo out effect.png](https://bugs.launchpad.net/mixxx/+bug/1793232/+attachment/5190352/+files/echo out effect.png)

[mixxxbot]

Commented by: Be-ing
Date: 2018-09-18T23:37:54Z

---

This was implemented in #1350 for 2.1. Has there been a regression?

[mixxxbot]

Commented by: uklotzde
Date: 2018-09-19T09:51:23Z

---

Confirmed for both 2.1.4 as well as 2.2 :(

[mixxxbot]

Commented by: Be-ing
Date: 2018-09-19T12:06:42Z

---

I compiled commit c74c08f from that pull request and indeed the issue is present there too. I guess I did not test carefully enough when working on that.

[mixxxbot]

Commented by: uklotzde
Date: 2018-10-31T09:14:36Z

---

Probably related: https://bugs.launchpad.net/mixxx/+bug/1800771

[mixxxbot]

Commented by: Be-ing
Date: 2018-10-31T11:16:57Z

---

#1878

[mixxxbot]

Issue closed with status Fix Released.