sync uses the first playing or the last not playing deck

[mixxxbot]

Reported by: daschuer
Date: 2018-07-28T23:21:26Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1784185
Tags: sync

---

When syncing a deck, it picks the first playing deck as reference. In case no deck is playing, it picks the last loaded deck. This is inconsistent, it should pick the first loaded deck in the later case as well.

[mixxxbot]

Commented by: rryan
Date: 2018-09-21T00:17:38Z

---

I don't feel strongly either way, but I wonder why Owen did it this way. He may have a reason.

[mixxxbot]

Commented by: ywwg
Date: 2018-09-21T09:56:48Z

---

When the DJ isn't using master sync, we have to guess which deck they want to sync to. I think the reasoning was: We should pick a playing deck as a reference, and absent any other information, the first one will do.

In the second case, if there is no playing deck, then the last-loaded deck was likely to be the one the DJ was just listening to, so that seems like a fine sync source.

First-loaded doesn't seem right to me because that track is probably further back in the past, but since this is a case where no other deck is playing, it may work fine. An alternative consistent logic could be, in order of priority:

1. Sync to master clock
2. Last-loaded playing deck if possible
3. Last-loaded non-playing deck if necessary

[mixxxbot]

Commented by: daschuer
Date: 2018-09-22T23:24:19Z

---

We may consider to respect the load or play order of a deck.
Currently only the Mixxx initialization order is used:

mixxx/src/engine/sync/enginesync.cpp

Line 113 in 9da873a

foreach (const Syncable* other_deck, m_syncables) {

For me this is highly reliable to sync always to the deck with the lowest index. I think if we change it to the Deck the user has last touched, that could be surprising.

Looking at the code, I consider the current situation a side effect of the implementation which should be IMHO fixed.

[mixxxbot]

Commented by: daschuer
Date: 2018-09-23T00:26:17Z

---

#1818

[mixxxbot]

Issue closed with status Fix Released.