(fix) Track Info: show key text as in tracks table #14020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0dB
reviewed
Dec 14, 2024
src/library/dlgtrackinfo.cpp
Outdated
| @@ -744,7 +744,7 @@ mixxx::UpdateResult DlgTrackInfo::updateKeyText() { | |||
| } | |||
|
|
|||
| void DlgTrackInfo::displayKeyText() { | |||
| const QString keyText = KeyUtils::keyToString(m_trackRecord.getKeys().getGlobalKey()); | |||
| const QString keyText = m_pLoadedTrack ? m_pLoadedTrack->getKeyText() : QStringLiteral(""); | |||
There was a problem hiding this comment.
Hm, I wonder if this is enough. In #14008 I found that getKeyText() could be empty and I had to use getKey().
There was a problem hiding this comment.
yeah, might also be getKeys().getGlobalKey().
I'm still digging a bit, trying to understand how the metadata flow is supposed to work.
|
Yes! |
ronso0
force-pushed
the
keytext-trackinfo
branch
from
3114e59 to
26c6d4b
Compare
ronso0
force-pushed
the
keytext-trackinfo
branch
from
26c6d4b to
212d226
Compare
ronso0
force-pushed
the
keytext-trackinfo
branch
from
212d226 to
08236b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14019 butit feels like this is just a workaround.
(I didn't look into the Track / TrackRecord details)
Seems like TrackRecord doesn't hold the key text from the database, whereas
BaseTrackCache::getTrackValueForColumn()takes the Track's key text.quoting my findings from #14011 (comment) again:
Max Graef - Jazz 104, FLAC
Based on #14011, so it's only the last commit.