Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rubberband v4 RubberBandLiveShifter for PitchShiftEffect #13973

Open
Swiftb0y opened this issue Dec 4, 2024 · 1 comment
Open

Use Rubberband v4 RubberBandLiveShifter for PitchShiftEffect #13973

Swiftb0y opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels

Comments

@Swiftb0y
Copy link
Member

Swiftb0y commented Dec 4, 2024

Recently released Rubberband 4.0 contains a new RubberBandLiveShifter that does not support time scaling but only frequency scaling. That is perfect for our PitchShiftEffect. It also has a simpler API that works with fixed size sample input and output counts (similar to our own DSP code). It does this while still minimizing latency. We should consider using it for our PitchShiftEffect instead of the RubberBandStretcher-based solution. It may reduce the realtime latency that the effect currently introduces.

CC @davidchocholaty in case you're interested in a follow up to your GSoC project.

@davidchocholaty
Copy link
Contributor

Thank you for letting me know. Based on your writing, the new Rubber Band improvements sound great. Interested in how it can help reduce the latency. Yeah, definitely. I want to take a look at this. Could you please assign me to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants