Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbox drop-down list is not styled #12323

Closed
JoergAtGithub opened this issue Nov 20, 2023 · 9 comments
Closed

Searchbox drop-down list is not styled #12323

JoergAtGithub opened this issue Nov 20, 2023 · 9 comments

Comments

@JoergAtGithub
Copy link
Member

Bug Description

grafik

Version

2.4

OS

Windows 11

@ronso0
Copy link
Member

ronso0 commented Nov 20, 2023

Can you try adding
WSearchLineEdit QAbstractScrollArea,
here

WEffectSelector QAbstractScrollArea,
?

@JoergAtGithub
Copy link
Member Author

Yes, now it became readable:
grafik
But the blue highlight color looks odd.

@ronso0
Copy link
Member

ronso0 commented Nov 21, 2023

Is this with Qt5?
Has it always been like this, or is this some regression?
Did you upgrade Qt recently?

I'm not surprised that quirks are required for Windows, I just can't belive it hasn't been noticed until now.

Good to see it can be addressed without bending over. I'll prepare a PR. Appearantly it's just that WSearchLineEdit QAbstractScrollArea does not inherit the styles from WSearchLineEdit.

@ronso0 ronso0 changed the title Drop-Down list of previous search querys is unreadable dark Searchbox drop-down list is not styled Nov 21, 2023
@ronso0
Copy link
Member

ronso0 commented Nov 21, 2023

When you took the selection screenshot, did you hover the item with the mouse or did you select it with the keyboard / controller?

Do the effect selectors (standard units and QuickEffects) look okay?

@JoergAtGithub
Copy link
Member Author

Effect dropdowns look Ok, except that the blue highlight color from the general desktop theme is used:
grafik
grafik
This is 2.4 with the Qt5 version from VCPKG, which we haven't changed for some months. I can't say if the search query dropdown changed over time.

@ronso0
Copy link
Member

ronso0 commented Nov 21, 2023

Okay, thanks.
How does AutoDJ's fade mode combobox look like?

I think we need to use selectors like this WEffectSelector QAbstractItemView like we do for the tracks table.
Please test if adding this

  WEffectSelector QAbstractItemView,
  WEffectChainPresetSelector QAbstractItemView,
  WSearchLineEdit QAbstractItemView,
  #fadeModeCombobox QAbstractItemView {
    selection-color: #fff;
    selection-background-color: #2c454f;
    border-radius: 1px;
    border: 0px;
    outline: none;
  }

here

/* checked item */

fixes the styling.

@JoergAtGithub
Copy link
Member Author

Indeed, this works. Now it looks like this:
grafik
grafik
grafik
grafik

@ronso0
Copy link
Member

ronso0 commented Nov 21, 2023

okay, great.
This was LateNight, could you please check those 3 comboboxes in the other skins? Seqrch, effects, fade mode

@JoergAtGithub
Copy link
Member Author

Deere:
grafik
grafik
grafik

Shade:
grafik
grafik
grafik

Tango:
grafik
grafik
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants