Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sampler's "end_of_track" control is not created #12304

Closed
ronso0 opened this issue Nov 15, 2023 · 0 comments · Fixed by #12305
Closed

sampler's "end_of_track" control is not created #12304

ronso0 opened this issue Nov 15, 2023 · 0 comments · Fixed by #12305

Comments

@ronso0
Copy link
Member

ronso0 commented Nov 15, 2023

Sampler's "end_of_track" control is not created if the sampler count in samplers.xml is lower than the samplers requested by a skin.
(and indeed the eot highlight is not drawn in the affected sample decks)

warning [Main] ControlDoublePrivate::getControl returning NULL for ( "[Sampler17]" , "end_of_track" )

I noticed these warnings in the log but couldn't reproduce immediatley, even though it's easy:
just delete samplers.xml (like with a fresh profile), or remove some lines, and you'll get the warnings.

While writing this, and taking a look at DeckVisuals / Visualsmanager (creator of the eot control), the cause is clear:
PlayerManager doesn't have a sampler equivalent for emit numberOfDecksChanged(m_decks.count());.
Fix should be easy it seems.

@ronso0 ronso0 linked a pull request Nov 15, 2023 that will close this issue
@ronso0 ronso0 closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant