Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scratching waveform backwards with a saved, active loop ahead temporarily jumps to that loop (visuals only) #12274

Closed
ronso0 opened this issue Nov 8, 2023 · 7 comments · Fixed by #12281

Comments

@ronso0
Copy link
Member

ronso0 commented Nov 8, 2023

  • create a hotcue loop
  • jump back a few bars
  • play
  • ativate loop (catching loop)
  • drag waveform forwards = visuals as expected
  • drag waveform backwards = visual position jumps to loop (audio is not affected)
waveform.loopcue.mp4

Version

2.4-beta-216-g5454b94b71

OS

Ubuntu Studio 20.04 / X11 / xfce 4.14 / Qt 5.12.8

@ronso0 ronso0 added this to the 2.4.0 milestone Nov 8, 2023
@ronso0
Copy link
Member Author

ronso0 commented Nov 8, 2023

I reproduced with a regular (temp, unsaved) re-loop and, while it also jumps, it did once jump while scratching forward 🤷‍♂️

@Swiftb0y

This comment was marked as off-topic.

@Swiftb0y
Copy link
Member

Swiftb0y commented Nov 8, 2023

I can also confirm your original exact issue.

@ronso0
Copy link
Member Author

ronso0 commented Nov 8, 2023

@JoergAtGithub Maybe a regression caused by #11840 ?

@ronso0
Copy link
Member Author

ronso0 commented Nov 8, 2023

Also, I did not yet test with 'real' scratching, only with the waveforms.

@Swiftb0y
Copy link
Member

Swiftb0y commented Nov 8, 2023

If with "real" scratching you mean via a controller or DVS then I'm pretty sure its unaffected its also equally affected. The issue with the mouse position is probably that it "pins" an unreachable position while instead we should probably only use the mouse movement and derive some relative scratching action from that. But I actually now think that that issue is unrelated to this one.

@JoergAtGithub
Copy link
Member

JoergAtGithub commented Nov 9, 2023

I can confirm both issues, the one reported by @ronso0 is indeed a regression of #11840. The issue reported by @Swiftb0y affects also earlier commits (seen with 679e4dc the commit before merging #11840), I moved it in a dedicated issue (#12278) therefore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants