Traktor Kontrol S3 HID script has an uncaught exception

[mixxxbot]

Reported by: marina711
Date: 2022-02-11T21:22:19Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1960680
Attachments: [This is the script I downloaded](https://bugs.launchpad.net/bugs/1960680/+attachment/5565086/+files/This is the script I downloaded), Traktor-Kontrol-S3-hid-scripts.js (patched)

---

After the automatic update to Mixxx 2.3.2 I get this error message when starting:

Uncaught exception at line 1912 in file /usr/share/mixxx/controllers/Traktor-Kontrol-S3-hid-scripts.js.

Exception:
TypeError: Result of expression 'engine.makeUnbufferedConnection' [undefined] is not a function.

Backtrace:
  <anonymous>() at /usr/share/mixxx/controllers/Traktor-Kontrol-S3-hid-scripts.js:1912
  <anonymous>(_id = 'Traktor Kontrol S3 6DF9_3', false) at /usr/share/mixxx/controllers/Traktor-Kontrol-S3-hid-scripts.js:2261
  <global>() at -1

reverted back to version 2.3.1 for the time beeing, cause it works.

[mixxxbot]

Commented by: uklotzde
Date: 2022-02-11T22:58:15Z

---

https://github.com/mixxxdj/mixxx/pull/4646/files#r805058829

[mixxxbot]

Commented by: marina711
Date: 2022-03-02T19:38:38Z
Attachments: [This is the script I downloaded](https://bugs.launchpad.net/mixxx/+bug/1960680/+attachment/5565086/+files/This is the script I downloaded)

---

I downloaded the patched script and did the upgrade to 2.3.2.1, then replaced the original script with the patched script but I still get this error message:

Uncaught exception at line 1912 in file /usr/share/mixxx/controllers/Traktor-Kontrol-S3-hid-scripts.js.

Exception:
TypeError: Result of expression 'engine.makeUnbufferedConnection' [undefined] is not a function.

Backtrace:
  <anonymous>() at /usr/share/mixxx/controllers/Traktor-Kontrol-S3-hid-scripts.js:1912
  <anonymous>(_id = 'Traktor Kontrol S3 6DF9_3', false) at /usr/share/mixxx/controllers/Traktor-Kontrol-S3-hid-scripts.js:2261
  <global>() at -1

Looks like the patch need another patch.

Regards
Marina

[mixxxbot]

Commented by: ywwg
Date: 2022-03-03T22:09:59Z

---

sorry for the trouble. You can do this yourself, replace "engine.makeUnbufferedConnection" with "engine.makeConnection" everywhere it appears.

[mixxxbot]

Commented by: marina711
Date: 2022-03-04T12:29:01Z
Attachments: Traktor-Kontrol-S3-hid-scripts.js (patched)

---

Did that and now, finally, it works.

Thanks Owen for the quick resolution

[mixxxbot]

Issue closed with status Fix Released.