Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opus files with artwork crashes mixxx 2.4-alpha-774 #10500

Closed
mixxxbot opened this issue Aug 23, 2022 · 18 comments
Closed

opus files with artwork crashes mixxx 2.4-alpha-774 #10500

mixxxbot opened this issue Aug 23, 2022 · 18 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: geozubuntu
Date: 2021-08-22T17:56:48Z
Status: Fix Committed
Importance: High
Launchpad Issue: lp1940777
Attachments: [suddenly closed session log](https://bugs.launchpad.net/bugs/1940777/+attachment/5519805/+files/suddenly closed session log), Report.wer, [the backtrace you requested.. (instructions need some improvement... )](https://bugs.launchpad.net/bugs/1940777/+attachment/5521345/+files/the backtrace you requested.. (instructions need some improvement... ))


Mixxx version 2.4-alpha-774-gc9df5af964 (main) for win10 64

CPU Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz 1.80 GHz
RAM 8,00 GB (7,88 GB Usable
System OS 64 bit, CPU architecture x64
Windows 10 Home
version 21H1
windows build 19043.1165

Mixxx crashes and closes immediately when try to load any opus track with embedded artwork. Reopening the program doesn't solve the problem. Mixxx has no problem and works normally with mp3, m4a, wav, flac, ogg. It happens only to opus tracks. If I clear the embedded coverart the track opens with no problem. It isn't happening with opus tracks without embedded coverart. If the coverart is set to be loaded from local directory it opens normally.
Only embedded artworks produces the problem no matter if the option "show coverart" is selected or not.

Attached the mixxx.log
The last entry is the file withou embedded coverart and was loaded succesfully. All above with greek characters are opus tracks without embedded artwork which also loaded successfully.

The track with the embedded artwork crashed and thats why it doesn't appear in the log. it happens with every opus file with embedded coverart, I tried more then 20 files.

Please try to fix this because when you search from a list of songs in a collection artwork is part of DJs memory, DJ remembers the album by the artwork then recall the tracks inside and that's crucial in a live performance.

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2021-08-22T17:56:48Z
Attachments: [suddenly closed session log](https://bugs.launchpad.net/mixxx/+bug/1940777/+attachment/5519805/+files/suddenly closed session log)

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-22T21:00:55Z


The test file contains artwork and does not crash Mixxx: https://github.com/mixxxdj/mixxx/raw/main/src/test/id3-test-data/cover-test.opus

Please provide a backtrace.

Alternatively provide a link to the file by private message for verification.

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2021-08-24T21:54:49Z
Attachments: Report.wer


The test file indeed contains artwork and does Crash Mixxx 2.4-alpha-774-gf2258d1a92 (main). I completely uninstall Mixxx and cleared any trace of it from registry and disk. rebooted and reinstalled from scratch mixxx 2.4-alpha-775-gf2258d1a92 (main).
I only imported the test file . The creative commons sign appeared as artwork but when I double klicked the test file mixxx crashed as usual.

event viewer report attached

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-24T22:32:33Z


I cannot reproduce this on Linux. Everything works as expected.

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2021-08-25T19:50:10Z


I also can't reproduce it on linux. Only in windows it is happening.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-25T20:09:21Z


This is very likely caused by a dependency on Windows, either TagLib or libopus/libobusfile.

TagLib is unlikely, because otherwise you wouldn't see the cover art in the library view.

Does this also happen with 2.3? Nothing changed since then, we are using the same library versions.

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2021-08-28T16:01:55Z


In my Lenovo laptop with windows 10 fully updated, no VM.

I completely uninstalled mixxx 2.4 from my computer using Revo uninstaller to remove any leftovers and reference of the program in registry and filesystem.
I used wise registry cleaner to verify the absence of any leftover registry entries regarding Mixxx.
I also removed any mixxx reference from Registry using Regedit as administrator.
I removed all prefetch files.
Finally I rebooted

I downloaded and installed latest mixxx 2.3.0-46-ge1408fabb2-win64.
I run it, imported only the test file: https://github.com/mixxxdj/mixxx/raw/main/src/test/id3-test-data/cover-test.opus and the program works fine. No problem. I imported my database and all my files were OK. No more crashes with ver 2.3.

Then I repeated all the above steps one by one but downloaded and installed 2.4-alpha-779-g49f9169228-win64. I imported only the test file and Mixxx 𝗰𝗿𝗮𝘀𝗵𝗲𝗱 again immediately.

I again uninstalled v 2.4 and installed v 2.3 and once again 𝙣𝙤 𝙥𝙧𝙤𝙗𝙡𝙚𝙢 with this version

So It is 𝙙𝙚𝙛𝙞𝙣𝙞𝙩𝙚𝙡𝙮 a 2.4 windows version problem, or the 2.4 installer doesn't install something properly.

I think to stick to 2.3 for now even if I need the search history functionality of 2.4.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-08-28T16:17:51Z


2.4 is not even in beta yet so we don't recommend it for general use. But thank you for reporting and investigating this.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-28T16:24:45Z


Could you try to generate and attach a backtrace for the crash?

https://github.com/mixxxdj/mixxx/wiki/Creating-Backtraces#windows

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2021-08-28T17:48:57Z
Attachments: [the backtrace you requested.. (instructions need some improvement... )](https://bugs.launchpad.net/mixxx/+bug/1940777/+attachment/5521345/+files/the backtrace you requested.. (instructions need some improvement... ))

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-28T19:35:53Z


Possible fix: #4251

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-28T19:40:29Z


Please test the Windows build artifact from the PR when finished and report if this fixes your issues.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-28T20:53:58Z


Intermediate workaround for 2.3.1: #4252

The obscure Windows crash might depend on compiler version and settings and could also affect future builds of 2.3.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-29T17:09:24Z


New builds are available: https://downloads.mixxx.org/snapshots/main/mixxx-2.4-alpha-783-g6f4fc8e9f2-win64.msi

Please report if this fixes your issue.

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2021-08-30T21:11:09Z


YES !! 2.4-alpha 783 fixes the issue.
Now all my opus files are loading and play. No crashes any more.

Thanks !

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-30T21:21:31Z


Thanks for the report!

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-08-30T21:22:44Z


Hopefully 2.3.1 will not suffer from this issue with only the minor fix in place.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant