-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opus files with artwork crashes mixxx 2.4-alpha-774 #10500
Comments
Commented by: geozubuntu |
Commented by: uklotzde The test file contains artwork and does not crash Mixxx: https://github.com/mixxxdj/mixxx/raw/main/src/test/id3-test-data/cover-test.opus Please provide a backtrace. Alternatively provide a link to the file by private message for verification. |
Commented by: geozubuntu The test file indeed contains artwork and does Crash Mixxx 2.4-alpha-774-gf2258d1a92 (main). I completely uninstall Mixxx and cleared any trace of it from registry and disk. rebooted and reinstalled from scratch mixxx 2.4-alpha-775-gf2258d1a92 (main). event viewer report attached |
Commented by: uklotzde I cannot reproduce this on Linux. Everything works as expected. |
Commented by: geozubuntu I also can't reproduce it on linux. Only in windows it is happening. |
Commented by: uklotzde This is very likely caused by a dependency on Windows, either TagLib or libopus/libobusfile. TagLib is unlikely, because otherwise you wouldn't see the cover art in the library view. Does this also happen with 2.3? Nothing changed since then, we are using the same library versions. |
Commented by: geozubuntu In my Lenovo laptop with windows 10 fully updated, no VM. I completely uninstalled mixxx 2.4 from my computer using Revo uninstaller to remove any leftovers and reference of the program in registry and filesystem. I downloaded and installed latest mixxx 2.3.0-46-ge1408fabb2-win64. Then I repeated all the above steps one by one but downloaded and installed 2.4-alpha-779-g49f9169228-win64. I imported only the test file and Mixxx 𝗰𝗿𝗮𝘀𝗵𝗲𝗱 again immediately. I again uninstalled v 2.4 and installed v 2.3 and once again 𝙣𝙤 𝙥𝙧𝙤𝙗𝙡𝙚𝙢 with this version So It is 𝙙𝙚𝙛𝙞𝙣𝙞𝙩𝙚𝙡𝙮 a 2.4 windows version problem, or the 2.4 installer doesn't install something properly. I think to stick to 2.3 for now even if I need the search history functionality of 2.4. |
Commented by: Be-ing 2.4 is not even in beta yet so we don't recommend it for general use. But thank you for reporting and investigating this. |
Commented by: uklotzde Could you try to generate and attach a backtrace for the crash? https://github.com/mixxxdj/mixxx/wiki/Creating-Backtraces#windows |
Commented by: geozubuntu |
Commented by: uklotzde Please test the Windows build artifact from the PR when finished and report if this fixes your issues. |
Commented by: uklotzde New builds are available: https://downloads.mixxx.org/snapshots/main/mixxx-2.4-alpha-783-g6f4fc8e9f2-win64.msi Please report if this fixes your issue. |
Commented by: geozubuntu YES !! 2.4-alpha 783 fixes the issue. Thanks ! |
Commented by: uklotzde Thanks for the report! |
Commented by: uklotzde Hopefully 2.3.1 will not suffer from this issue with only the minor fix in place. |
Issue closed with status Fix Committed. |
Reported by: geozubuntu
Date: 2021-08-22T17:56:48Z
Status: Fix Committed
Importance: High
Launchpad Issue: lp1940777
Attachments: [suddenly closed session log](https://bugs.launchpad.net/bugs/1940777/+attachment/5519805/+files/suddenly closed session log), Report.wer, [the backtrace you requested.. (instructions need some improvement... )](https://bugs.launchpad.net/bugs/1940777/+attachment/5521345/+files/the backtrace you requested.. (instructions need some improvement... ))
Mixxx version 2.4-alpha-774-gc9df5af964 (main) for win10 64
CPU Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz 1.80 GHz
RAM 8,00 GB (7,88 GB Usable
System OS 64 bit, CPU architecture x64
Windows 10 Home
version 21H1
windows build 19043.1165
Mixxx crashes and closes immediately when try to load any opus track with embedded artwork. Reopening the program doesn't solve the problem. Mixxx has no problem and works normally with mp3, m4a, wav, flac, ogg. It happens only to opus tracks. If I clear the embedded coverart the track opens with no problem. It isn't happening with opus tracks without embedded coverart. If the coverart is set to be loaded from local directory it opens normally.
Only embedded artworks produces the problem no matter if the option "show coverart" is selected or not.
Attached the mixxx.log
The last entry is the file withou embedded coverart and was loaded succesfully. All above with greek characters are opus tracks without embedded artwork which also loaded successfully.
The track with the embedded artwork crashed and thats why it doesn't appear in the log. it happens with every opus file with embedded coverart, I tried more then 20 files.
Please try to fix this because when you search from a list of songs in a collection artwork is part of DJs memory, DJ remembers the album by the artwork then recall the tracks inside and that's crucial in a live performance.
The text was updated successfully, but these errors were encountered: