Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreviewButtonDelegate: Debug assertion #10418

Closed
mixxxbot opened this issue Aug 23, 2022 · 10 comments
Closed

PreviewButtonDelegate: Debug assertion #10418

mixxxbot opened this issue Aug 23, 2022 · 10 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: uklotzde
Date: 2021-05-20T22:57:09Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1929141
Tags: library


While entering a search query:

mixxxdj/mixxx#4913  0x000000000049d9ca in mixxx_debug_assert(char const*, char const*, int, char const*)
    (assertion=assertion@entry=0x10aacd8 "index != m_currentEditedCellIndex", file=file@entry=0x10aaca8 "../src/library/previewbuttondelegate.cpp", line=line@entry=177, function=function@entry=0x10aac68 "void PreviewButtonDelegate::cellEntered(const QModelIndex&)") at ../src/util/assert.h:11
mixxxdj/mixxx#4914  0x00000000004fbbc2 in PreviewButtonDelegate::cellEntered(QModelIndex const&) (this=0x2d63a220, index=...) at ../src/library/previewbuttondelegate.cpp:177
mixxxdj/mixxx#4915  0x00007ffff3eb04b0 in void doActivate<false>(QObject*, int, void**) () at /lib64/libQt5Core.so.5
mixxxdj/mixxx#4916  0x00007ffff71501c9 in QAbstractItemView::entered(QModelIndex const&) () at /lib64/libQt5Widgets.so.5
mixxxdj/mixxx#4917  0x00007ffff715dfd0 in QAbstractItemViewPrivate::checkMouseMove(QPersistentModelIndex const&) () at /lib64/libQt5Widgets.so.5
mixxxdj/mixxx#4918  0x00007ffff715e23d in QAbstractItemView::mouseMoveEvent(QMouseEvent*) () at /lib64/libQt5Widgets.so.5
mixxxdj/mixxx#4919 0x00007ffff6f3585e in QWidget::event(QEvent*) () at /lib64/libQt5Widgets.so.5

Continuing in the debugger worked without any issues.

Preview column was visible but not used.

@mixxxbot
Copy link
Collaborator Author

Commented by: Holzhaus
Date: 2021-07-20T09:48:45Z


I encountered this too by accident:

DEBUG ASSERT: "index != m_currentEditedCellIndex" in function void PreviewButtonDelegate::cellEntered(const QModelIndex&) at /home/jan/Projects/mixxx/src/library/previewbuttondelegate.cpp:177

@mixxxbot
Copy link
Collaborator Author

Commented by: Holzhaus
Date: 2021-07-20T09:53:57Z


I think this only affects main, searching works on the 2.3 branch.

@mixxxbot
Copy link
Collaborator Author

Commented by: Holzhaus
Date: 2021-07-20T10:43:03Z


This also makes the browse view completely unusable. Clicking any cell in the track table triggers it.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-07-20T10:43:20Z


I remember to have experienced this once or twice in the past. No idea when or why it happens.

@mixxxbot
Copy link
Collaborator Author

Commented by: Holzhaus
Date: 2021-08-16T19:04:23Z


Just encountered this again:

DEBUG ASSERT: "index != m_currentEditedCellIndex" in function void PreviewButtonDelegate::cellEntered(const QModelIndex&) at /home/jan/Projects/mixxx/src/library/previewbuttondelegate.cpp:177

I found how to reproduce this reliably:

  1. Start Mixxx
  2. Click somewhere in the tracks table
  3. Press CTRL+A to select all tracks
  4. Drag them on the analysis feature
  5. Click a cell in the preview column -> DEBUG_ASSERT is triggered

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-09-05T12:52:11Z


This bugs me frequently, will fix it.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-09-05T13:12:10Z


This might also affect 2.3, but only the development snapshots.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-09-05T13:30:57Z


Not critical, because it works as expected when ignoring the debug assertion.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-09-05T22:18:02Z


#4264

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.1 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant