Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Options Don't Invalidate the Cache #490

Open
deckar01 opened this issue May 19, 2017 · 1 comment
Open

Filter Options Don't Invalidate the Cache #490

deckar01 opened this issue May 19, 2017 · 1 comment

Comments

@deckar01
Copy link

In #489 I spent a lot of time debugging why babel wouldn't work only to find out that the first run didn't have the presets option, but after it was added the original output remained in the cache.

Step to reproduce:

  1. Add a filter to a bundle
  2. Build the bundled asset
  3. Change an option for the filter
  4. Build the bundled asset

What happened:

The build after the option was changed still fetched the asset from the cache even though the filter might output different content.

What should have happened:

Modifying the filter option should have invalidated the cache on the next build.

Suggested fixes:

Incorporate the filter options into the cache's hash.

@deckar01
Copy link
Author

This issue seems to persist even after disabling the cache and the manifest.

environment.assets_environment.cache = False
environment.assets_environment.manifest = False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant