-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add related, fix manual ooi task list, remove redundant octopoes call #3421
Conversation
@@ -24,7 +24,11 @@ <h2>{% translate "Last observed by" %}</h2> | |||
<a href="{% url 'boefje_detail' organization_code=organization.code plugin_id=observation.boefje.id %}" | |||
title="{{ observation.boefje.id }}">{{ observation.boefje.name }}</a> | |||
{% else %} | |||
{% translate "The boefje has since been deleted or disabled." %} | |||
{% if observation.normalizer.raw_data.boefje_meta.boefje.id == "manual" %} | |||
{% translate "This scan was manually created." %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really blocking, but maybe "The raw file was uploaded manually" or "This scan was done manually" is better than "This scan was manually created"? In the case OOIs are just added manually they don't have to be the result of a scan, so I think saying that there was a manual upload instead of scan is more accurate.
Checklist for QA:
What works:Tested that the dropdown shows up when clicking the 'Add' button on a 'Related Objects' page. This works. Links from the normalizers (from newly added objects) also are clickable from the normalizer Tasks tab. What doesn't work:n/a Bug or feature?:n/a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Very minimal remarks, consider it approved
Co-authored-by: ammar92 <[email protected]>
Co-authored-by: ammar92 <[email protected]>
Changes
Two fixes:
Demo
QA notes
Add related: go to ooi detail and click "Add" under the related objects. Show now work again.
After adding a raw file, in the ooi detail, the observation should now show: Scan was added manually.
Whole ooi detail should be QA'ed because the view inheritance has changed so there is a chance of regressions.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.