Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sec vul CVE-2022-28948 from pkg/credentials > ini.v1 > stretchr/testify > yaml.v3 #1968

Closed
amaciejk opened this issue Jun 3, 2024 · 1 comment · Fixed by #1977
Closed

Comments

@amaciejk
Copy link

amaciejk commented Jun 3, 2024

We are using latest minio-go v7.0.70 and are seeing:
GHSA-hp87-p4gw-j4gq
https://nvd.nist.gov/vuln/detail/CVE-2022-28948

image

Dep tree is:

github.com/minio/minio-go/v7/pkg/credentials
gopkg.in/ini.v1
gopkg.in/ini.v1.test
github.com/stretchr/testify/assert
gopkg.in/yaml.v3

an updated go.sum shows:

github.com/minio/minio-go/v7 v7.0.70 h1:1u9NtMgfK1U42kUxcsl5v0yj6TEOPR497OAQxpJnn2g=
github.com/minio/minio-go/v7 v7.0.70/go.mod h1:4yBA8v80xGA30cfM3fz0DKYMXunWl/AV/6tWEs9ryzo=
github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
gopkg.in/ini.v1 v1.67.0 h1:Dgnx+6+nfE+IfzjUEISNeydPJh9AXNNsWbGP9KzCsOA=
gopkg.in/ini.v1 v1.67.0/go.mod h1:pNLf8WUiyNEtQjuu5G5vTm06TEv9tsIgeAvK8hOrP4k=
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

2020 seems quite old compared to 2022 or latest even.

Looks like stretchr/testify have fixed in v1.8.4 or later:
stretchr/testify#1532
so perhaps it is ini.v1 that needs fixing?

@marktheunissen
Copy link
Contributor

Thanks @amaciejk this is from testing code in a dependancy (note gopkg.in/ini.v1.test in your dep tree) but it's worth updating these so that vulnerability scanners don't report false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants