Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improperly overriding directory attribute when init_app is used. #78

Closed
timmartin19 opened this issue Aug 28, 2015 · 0 comments · Fixed by #79
Closed

Improperly overriding directory attribute when init_app is used. #78

timmartin19 opened this issue Aug 28, 2015 · 0 comments · Fixed by #79

Comments

@timmartin19
Copy link
Contributor

When the following code is used:

migrate = Migrate(directory='/path/to/migrations')
migrate.init_app(app, db)

The directory gets reset to migrations since that is the default.
timmartin19 added a commit to timmartin19/Flask-Migrate that referenced this issue Aug 28, 2015
@timmartin19
Updates so that directory doesn't get overridden
0c9a2cb 
Fixes miguelgrinberg#78 where directory gets overridden if it is not explicitly specified in init_app.  This fix allows it to be set when the `Migrate` object is initialized and not automatically get overridden when the `init_app` is called.  This is a non-breaking change.
@timmartin19 timmartin19 mentioned this issue Aug 28, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates so that directory doesn't get overridden timmartin19/Flask-Migrate
1 participant
@timmartin19