Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code web: quickpick disappear when a walkthrough is opened and focused #204522

Closed
vitaliy-guliy opened this issue Feb 6, 2024 · 16 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster *not-reproducible Issue cannot be reproduced by VS Code Team member as described verified Verification succeeded
Milestone

Comments

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Feb 6, 2024

I noticed that a few months ago some changes related to the focus in quickpick and in inputbox were pushed.
Today I faced a bug that seems appeared after that improvements.
The bug is relevant for the web version. I've checked the case on VS Code desktop 1.86.0 and did not get any issues.

Does this issue occur when all extensions are disabled?: Yes/No

An extension helps me to show the bug, no reason to disable it.

  • VS Code Version: 1.86.0, Version: 1.87.0
  • OS Version: -

Steps to Reproduce:
The bug is reproducible on gitpod. I've prepared a simple extension to demonstrate

  1. Go to Gitpod, create a workspace from https://github.com/vitaliy-guliy/vscode-test-extension
  2. if the extension is not compiled automatically, open a terminal, install dependencies with npm install and then compile the extension with npm run compile
  3. Run the extension
  4. In the secondary browser window open Welcome page and go to Test walkthrough and focus the tile
  5. Click Show button, enter some value and try to select any item from appeared quickpick.

In 99 percents the quickpick is appeared and then immediately closed.

A notification will show entered values.

Screenshot from 2024-02-06 20-33-25

@bhavyaus bhavyaus added the bug Issue identified by VS Code Team member as probable bug label Feb 8, 2024
@bhavyaus bhavyaus added this to the February 2024 milestone Feb 8, 2024
@bhavyaus
Copy link
Collaborator

@vitaliy-guliy I am unable to repro this issue.

Image

Have you also considered setting ignoreFocusOut in your InputBoxOptions

		/**
		 * Set to `true` to keep the input box open when focus moves to another part of the editor or to another window.
		 * This setting is ignored on iPad and is always false.
		 */
		ignoreFocusOut?: boolean;

@bhavyaus bhavyaus added the ~info-needed Issue requires more information from poster (with bot comment) label Feb 13, 2024
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@vscodenpa vscodenpa added info-needed Issue requires more information from poster and removed ~info-needed Issue requires more information from poster (with bot comment) labels Feb 13, 2024
@bhavyaus bhavyaus modified the milestones: February 2024, Backlog Feb 13, 2024
@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@vitaliy-guliy
Copy link
Contributor Author

@bhavyaus I also cannot reproduce this bug on gitpod anymore.
But it still reproducible in Eclipse Che nightly build with VS Code 1.88.0
Gitpod is still running with VS Code 1.87.0

I would not like to add ignoreFocusOut property as it makes the UX a bit confusing. The user have to focus the popup manually to continue entering the value.
This how does it look like with ignoreFocusOut: true property

Screenshot from 2024-03-04 14-55-57

Anyway, I will test it again on the Gitpod when it gets VS Code 1.88.x or later.
Thanks!

@vitaliy-guliy
Copy link
Contributor Author

vitaliy-guliy commented Mar 4, 2024

@bhavyaus The bug is reproducible on Github Codespaces with VS Code 1.85.2

Btw, I cannot reopen the issue. Was this restriction added intentionally?

@ibuziuk
Copy link

ibuziuk commented Mar 5, 2024

@bhavyaus could you please take a look? it looks like the issue is still actual and should be reopened

@bhavyaus
Copy link
Collaborator

bhavyaus commented Mar 6, 2024

Investigating..

@bhavyaus bhavyaus reopened this Mar 6, 2024
@bhavyaus bhavyaus modified the milestones: Backlog, March 2024 Mar 6, 2024
@bhavyaus bhavyaus removed the info-needed Issue requires more information from poster label Mar 6, 2024
@bhavyaus
Copy link
Collaborator

bhavyaus commented Mar 8, 2024

@vitaliy-guliy I am unable to repro this issue on Github Codespaces with VS Code 1.85.2. Could you please include a recording/gif of the repro.

@bhavyaus bhavyaus added *not-reproducible Issue cannot be reproduced by VS Code Team member as described ~info-needed Issue requires more information from poster (with bot comment) labels Mar 8, 2024
@vscodenpa
Copy link

We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our issue reporting guidelines might help you with that.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@vscodenpa vscodenpa added info-needed Issue requires more information from poster and removed ~info-needed Issue requires more information from poster (with bot comment) labels Mar 8, 2024
@vitaliy-guliy
Copy link
Contributor Author

@bhavyaus

simplescreenrecorder-2024-03-11_14.24.38.mp4

@vitaliy-guliy
Copy link
Contributor Author

@bhavyaus have you had a chance to try to reproduce the bug?

@vitaliy-guliy
Copy link
Contributor Author

I tried to reproduce it today, but seems it works

@bhavyaus
Copy link
Collaborator

bhavyaus commented Mar 18, 2024

Ill verify on my end if the VS Code version bump fixed it. There have been a few changes in this area in the last few iterations. - verified.

@vitaliy-guliy
Copy link
Contributor Author

@bhavyaus I no longer have any issues with VS Code built from sources. Thanks.

@justschen justschen added the verified Verification succeeded label Mar 27, 2024
@vitaliy-guliy
Copy link
Contributor Author

vitaliy-guliy commented Apr 18, 2024

I started to face the issue on gitpod again.
It is unstable and reproducible in 90% of cases

simplescreenrecorder-2024-04-18_13.18.56.mp4

Tested with Chrome Version 123.0.6312.58 on Linux Mint 20.2

@bhavyaus could you take a look?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster *not-reproducible Issue cannot be reproduced by VS Code Team member as described verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants