Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Adding a ExtensionVersion to ClientInfo #1366

Open
davidbarsky opened this issue Nov 16, 2023 · 1 comment
Open

Consider Adding a ExtensionVersion to ClientInfo #1366

davidbarsky opened this issue Nov 16, 2023 · 1 comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@davidbarsky
Copy link

Hello! I was wondering if y'all would accept a PR to add an ExtensionVersion to ClientInfo?

export interface ClientInfo {
/**
* The name of the client as defined by the client.
*/
name: string;
/**
* The client's version as defined by the client.
*/
version?: string;
}

(I'd also be okay with a grab-bag object of object!)

@dbaeumer
Copy link
Member

I am not against this. But it would need to go into the specification as well (https://microsoft.github.io/language-server-protocol/)

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Nov 17, 2023
@dbaeumer dbaeumer added this to the Backlog milestone Nov 17, 2023
@dbaeumer dbaeumer added the help wanted Issues identified as good community contribution opportunities label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

2 participants