-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NotebookEdit
in WorkspaceEdit
#1336
Comments
notebook/format
request typenotebookDocument/formatting
request type
How is this currently triggered via the VS Code API_ |
notebookDocument/formatting
request typenotebookDocument/formatting
request type
This currently isn't, I created this issue as a tracking item for getting details down for the protocol side. I will create and attach this to the core issue to trigger this from the VS Code side. |
Ok. Thanks! |
notebookDocument/formatting
request typenotebookDocument/formatting
request type
@dbaeumer : @rebornix and I are looking into this issue for this milestone. LSP work items might show up on this for the next milestone. We are working on figuring out the Core workspace edit API which actually supports notebooks edits, but there are some minor differences in how we handle addition and removal in LSP vs how it is done in the current Notebook API. Once we have that figured out we will create specific items needed from LSP for this task. |
notebookDocument/formatting
request typeNotebookEdit
in WorkspaceEdit
Currently there is no way to provide diffs at the notebook level. We currently receive notebook changes in the form of notebook synchronization events.
The Notebook features that are available from TS APIs like
WorkspaceEdit.set
is currently not exposed to Language Servers. Having this will allow language servers to perform notebook level "formatting" (restructuring), refactoring, insert/delete/re-order cells.Adding
NotebookEdit
support can generally allow updating notebooks via formatting, code action, or any request.Notes:
NotebookEdit
toWorkspaceEdit
, and also introduce aNotebookCellData
type since theNotebookCell
type is not sufficient to create new cells.WorkspaceEdit
API supportsNotebookEdit
: https://github.com/microsoft/vscode/blob/29e000b1e5c03e7c9a6fccf3e475f0b5a239e4d6/src/vscode-dts/vscode.d.ts#L3967NotebookCellData
: https://github.com/microsoft/vscode/blob/29e000b1e5c03e7c9a6fccf3e475f0b5a239e4d6/src/vscode-dts/vscode.d.ts#L14869-L14911ref: microsoft/vscode#204544
The text was updated successfully, but these errors were encountered: