Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow initializationOptions, fillInitializeParams, etc to be async #1283

Open
mroch opened this issue Aug 3, 2023 · 1 comment
Open

Allow initializationOptions, fillInitializeParams, etc to be async #1283

mroch opened this issue Aug 3, 2023 · 1 comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@mroch
Copy link
Contributor

mroch commented Aug 3, 2023

I want to do some async work to compute the initialization options and client capabilities.

Since BaseLanguageClient#initialize is already async, I'd like to make these calls also async:

capabilities: this.computeClientCapabilities(),
initializationOptions: Is.func(initOption) ? initOption() : initOption,

this.fillInitializeParams(initParams);

@dbaeumer dbaeumer added this to the Backlog milestone Aug 7, 2023
@dbaeumer dbaeumer added the help wanted Issues identified as good community contribution opportunities label Aug 7, 2023
@dbaeumer
Copy link
Member

dbaeumer commented Aug 7, 2023

A PR is welcome.

@dbaeumer dbaeumer added feature-request Request for new features or functionality and removed feature request labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

2 participants