Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added KRNN and Sandwich models and their example results based on Alpha360 #1414

Merged
merged 23 commits into from
May 26, 2023
Merged

added KRNN and Sandwich models and their example results based on Alpha360 #1414

merged 23 commits into from
May 26, 2023

Conversation

yaxuan999
Copy link
Contributor

@yaxuan999 yaxuan999 commented Jan 10, 2023 •
edited
Loading

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added documentation Improvements or additions to documentation waiting for triage Cannot auto-triage, wait for triage. labels Jan 10, 2023
@yaxuan999
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="MSRA"]

@yaxuan999
Copy link
Contributor Author

@microsoft-github-policy-service agree company="MSRA"

@yaxuan999
Copy link
Contributor Author

Contributor License Agreement installed

@yaxuan999 yaxuan999 closed this Mar 29, 2023
@yaxuan999 yaxuan999 reopened this Mar 29, 2023
@yaxuan999
Copy link
Contributor Author

@microsoft-github-policy-service agree company="MSRA"

@yaxuan999 yaxuan999 closed this Mar 30, 2023
@yaxuan999 yaxuan999 reopened this Mar 31, 2023
you-n-g
you-n-g requested changes Apr 14, 2023
View reviewed changes
examples/benchmarks/KRNN/README.md Show resolved Hide resolved
examples/benchmarks/Sandwich/README.md Show resolved Hide resolved
qlib/contrib/model/pytorch_krnn.py
return y


class KRNNEncoderBase(nn.Module):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we have 2 same KRNNEncoderBase in the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

qlib/contrib/model/pytorch_krnn.py
return hids


class CNNKRNNEncoder(nn.Module):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CNNKRNNEncoder have two similar version as well.
Please merge them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@you-n-g you-n-g merged commit efffb28 into microsoft:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you-n-g you-n-g you-n-g requested changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation waiting for triage Cannot auto-triage, wait for triage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaxuan999 @you-n-g