From 05cd275336b3c294202653a781854fb89b0f99e4 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Wed, 29 Apr 2020 08:09:47 -0700 Subject: [PATCH] feat(chromium): roll to r763809 --- README.md | 4 ++-- browsers.json | 2 +- install-from-github.js | 2 +- packages/playwright-chromium/browsers.json | 2 +- packages/playwright/browsers.json | 2 +- src/install/browserPaths.ts | 2 +- test/headful.spec.js | 4 ++-- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index f019f5f3e13f6..638cdb4b087bf 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # 🎭 Playwright -[![npm version](https://img.shields.io/npm/v/playwright.svg?style=flat)](https://www.npmjs.com/package/playwright) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://join.slack.com/t/playwright/shared_invite/enQtOTEyMTUxMzgxMjIwLThjMDUxZmIyNTRiMTJjNjIyMzdmZDA3MTQxZWUwZTFjZjQwNGYxZGM5MzRmNzZlMWI5ZWUyOTkzMjE5Njg1NDg) [![Chromium version](https://img.shields.io/badge/chromium-84.0.4122.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home) [![Firefox version](https://img.shields.io/badge/firefox-76.0b5-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/) [![WebKit version](https://img.shields.io/badge/webkit-13.0.4-blue.svg?logo=safari)](https://webkit.org/) +[![npm version](https://img.shields.io/npm/v/playwright.svg?style=flat)](https://www.npmjs.com/package/playwright) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://join.slack.com/t/playwright/shared_invite/enQtOTEyMTUxMzgxMjIwLThjMDUxZmIyNTRiMTJjNjIyMzdmZDA3MTQxZWUwZTFjZjQwNGYxZGM5MzRmNzZlMWI5ZWUyOTkzMjE5Njg1NDg) [![Chromium version](https://img.shields.io/badge/chromium-84.0.4131.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home) [![Firefox version](https://img.shields.io/badge/firefox-76.0b5-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/) [![WebKit version](https://img.shields.io/badge/webkit-13.0.4-blue.svg?logo=safari)](https://webkit.org/) ##### [Docs](docs/README.md) | [API reference](docs/api.md) | [Changelog](https://github.com/microsoft/playwright/releases) @@ -8,7 +8,7 @@ Playwright is a Node library to automate [Chromium](https://www.chromium.org/Hom | | Linux | macOS | Windows | | :--- | :---: | :---: | :---: | -| Chromium 84.0.4122.0 | :white_check_mark: | :white_check_mark: | :white_check_mark: | +| Chromium 84.0.4131.0 | :white_check_mark: | :white_check_mark: | :white_check_mark: | | WebKit 13.0.4 | :white_check_mark: | :white_check_mark: | :white_check_mark: | | Firefox 76.0b5 | :white_check_mark: | :white_check_mark: | :white_check_mark: | diff --git a/browsers.json b/browsers.json index aa0bde1a6fbc5..7e14f0cdae7d7 100644 --- a/browsers.json +++ b/browsers.json @@ -2,7 +2,7 @@ "browsers": [ { "name": "chromium", - "revision": "760827" + "revision": "763809" }, { "name": "firefox", diff --git a/install-from-github.js b/install-from-github.js index 9a9e0c8c12e74..603997ccae699 100644 --- a/install-from-github.js +++ b/install-from-github.js @@ -73,7 +73,7 @@ async function downloadAllBrowsersAndGenerateProtocolTypes() { } // Cleanup stale revisions. - const directories = new Set(await readdirAsync(path.join(__dirname, '.local-browsers'))); + const directories = new Set(await readdirAsync(browserPaths.browsersPath(__dirname))); for (const browser of browsers) directories.delete(browserPaths.browserDirectory(__dirname, browser)); await Promise.all([...directories].map(directory => rmAsync(directory))); diff --git a/packages/playwright-chromium/browsers.json b/packages/playwright-chromium/browsers.json index e2069feb21492..85cf984e86d42 100644 --- a/packages/playwright-chromium/browsers.json +++ b/packages/playwright-chromium/browsers.json @@ -2,7 +2,7 @@ "browsers": [ { "name": "chromium", - "revision": "760827" + "revision": "763809" } ] } diff --git a/packages/playwright/browsers.json b/packages/playwright/browsers.json index aa0bde1a6fbc5..7e14f0cdae7d7 100644 --- a/packages/playwright/browsers.json +++ b/packages/playwright/browsers.json @@ -2,7 +2,7 @@ "browsers": [ { "name": "chromium", - "revision": "760827" + "revision": "763809" }, { "name": "firefox", diff --git a/src/install/browserPaths.ts b/src/install/browserPaths.ts index d72eb7aa02a0e..96598a0384408 100644 --- a/src/install/browserPaths.ts +++ b/src/install/browserPaths.ts @@ -75,7 +75,7 @@ function getRelativeExecutablePath(browserName: BrowserName): string[] | undefin } } -function browsersPath(packagePath: string): string { +export function browsersPath(packagePath: string): string { const result = getFromENV('PLAYWRIGHT_BROWSERS_PATH'); return result || path.join(packagePath, '.local-browsers'); } diff --git a/test/headful.spec.js b/test/headful.spec.js index 7e3248d05e41b..92b63224bf734 100644 --- a/test/headful.spec.js +++ b/test/headful.spec.js @@ -57,7 +57,7 @@ describe('Headful', function() { await browserContext.close(); await removeUserDataDir(userDataDir); }); - it.fail(CHROMIUM)('should not crash when creating second context', async ({browserType, defaultBrowserOptions, server}) => { + it('should not crash when creating second context', async ({browserType, defaultBrowserOptions, server}) => { const browser = await browserType.launch({...defaultBrowserOptions, headless: false }); { const browserContext = await browser.newContext(); @@ -71,7 +71,7 @@ describe('Headful', function() { } await browser.close(); }); - it.fail(CHROMIUM)('should click background tab', async({browserType, defaultBrowserOptions, server}) => { + it('should click background tab', async({browserType, defaultBrowserOptions, server}) => { const browser = await browserType.launch({...defaultBrowserOptions, headless: false }); const page = await browser.newPage(); await page.setContent(`empty.html`);