Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Inspector] Stack won't extracted correctly if browser specific NPM packages are used #5588

Closed
mxschmitt opened this issue Feb 24, 2021 · 2 comments · Fixed by #5589
Closed

Comments

@mxschmitt
Copy link
Member

Code:

const { chromium } = require('playwright-chromium');

(async () => {
  const browser = await chromium.launch();
  const page = await browser.newPage();
  await page.goto('http://whatsmyuseragent.org/');
  await page.screenshot({ path: `example.png` });
  await browser.close();
})();

Actual:

image

Expected: When using playwright instead of playwright-chromium it works and shows the correct code in the Inspector window.

PWDEBUG=1 node test.js

@mxschmitt mxschmitt changed the title [BUG] [Inspector] Stack won't extracted correctly if browser specific NPM packages are used [BUG][Inspector] Stack won't extracted correctly if browser specific NPM packages are used Feb 24, 2021
@aslushnikov aslushnikov reopened this Feb 24, 2021
@aslushnikov
Copy link
Collaborator

(re-opening this since we'll likely merge this to v1.9.2)

@aslushnikov aslushnikov added v1.9.1 and removed v1.9.2 labels Feb 25, 2021
@aslushnikov
Copy link
Collaborator

This was merged in v1.9.1 and 1.9.1 is live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants