[REGRESSION][1.9.0]: Cannot find module 'electron' or its corresponding type declarations

[AviVahl]

Context:

• GOOD Playwright Version: 1.8.0
• BAD Playwright Version: 1.9.0
• Operating System: Linux. Fedora 33.
• Extra: using playwright-core. skipLibCheck is not turned on.

Code Snippet

const {chromium, webkit, firefox} = require('playwright-core');

(async () => {
  const browser = await chromium.launch();
  // ... 
})();

Describe the bug

After upgrading to the new version, I see the following type errors when using playwright-core programmatically:

node_modules/playwright-core/types/types.d.ts:7098:63 - error TS2307: Cannot find module 'electron' or its corresponding type declarations.
7098   evaluate<R, Arg>(pageFunction: PageFunctionOn<typeof import('electron'), Arg, R>, arg: Arg): Promise<R>;
                                                                   ~~~~~~~~~~

node_modules/playwright-core/types/types.d.ts:7099:58 - error TS2307: Cannot find module 'electron' or its corresponding type declarations.
7099   evaluate<R>(pageFunction: PageFunctionOn<typeof import('electron'), void, R>, arg?: any): Promise<R>;
                                                              ~~~~~~~~~~

node_modules/playwright-core/types/types.d.ts:7120:69 - error TS2307: Cannot find module 'electron' or its corresponding type declarations.
7120   evaluateHandle<R, Arg>(pageFunction: PageFunctionOn<typeof import('electron'), Arg, R>, arg: Arg): Promise<SmartHandle<R>>;
                                                                         ~~~~~~~~~~

node_modules/playwright-core/types/types.d.ts:7121:64 - error TS2307: Cannot find module 'electron' or its corresponding type declarations.
7121   evaluateHandle<R>(pageFunction: PageFunctionOn<typeof import('electron'), void, R>, arg?: any): Promise<SmartHandle<R>>;
                                                                    ~~~~~~~~~~

Found 4 errors.

[mxschmitt]

Sems like already fixed in #5572 and cherry-picked in #5576. Should get released as 1.9.1 shortly.

[aslushnikov]

The fix was merged in v1.9.1 and 1.9.1 is live!

[mxschmitt]

Can verify it works!

[joelgriffith]

Thanks @aslushnikov!

[aarvay]

Breaks in 1.10.0

[AviVahl]

Breaks in 1.10.0

odd. we're using 1.10.0 and no issue. re-verify the local version.

[aarvay]

Re-verified local version. 1.10.0.

node_modules/playwright-core/lib/server/electron/electron.js:129:66: error: Could not resolve "electron/index.js" (mark it as external to exclude it from the bundle)
    129 │ ...utablePath: options.executablePath || require('electron/index.js'),

[aarvay]

Last working version for me was 1.8.0. Even 1.9.1 doesn't work. I get the same error.

[AviVahl]

that doesn't look like a type error. which tool/lib is giving you this error?

[aarvay]

esbuild

[AviVahl]

ah, might want to open a separate issue and give exact steps to reproduce, expected behavior, etc...

[aarvay]

@AviVahl will do that! thanks.

[mikejackowski]

Still happening to me, playwright-core 1.20, building using tsc

Could not resolve "electron/index.js" (mark it as external to exclude it from the bundle)

[AviVahl]

@mikejackowski
That's not an error from tsc. It's an error from some bundler (I'm guessing esbuild, but you'd be the one to say).
You probably need to avoid trying to bundle playwright, or any test file that imports it.