Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add debug log when calling to waitForResponse/waitForRequest #5087

Closed
nadavkaner opened this issue Jan 21, 2021 · 3 comments · Fixed by #5093
Closed

[Feature] Add debug log when calling to waitForResponse/waitForRequest #5087

nadavkaner opened this issue Jan 21, 2021 · 3 comments · Fixed by #5093
Assignees
@dgozman

Comments

@nadavkaner
Copy link

When calling to waitForResponse/waitForRequest I don't see any debug logs, it can be very useful to have some debug log with the URL or the predicate in order to debug issues
@mxschmitt
Copy link
Member

What kind of debug logs do you expect to see or would be useful?

@pavelfeldman
Copy link
Member

You mean to pw:api entries whatsoever? Yeah, should be fixed.

@dgozman dgozman mentioned this issue Jan 21, 2021
Merged
@nadavkaner
Copy link
Author

nadavkaner commented Jan 21, 2021 •
edited
Loading

Yeah I mean to pw:api entries, I would expect to see some logs like for the other APIs, something like "waiting for network request/response [URL/predicate]..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(logs): add wrapApiCall for logging to many api methods
4 participants
@pavelfeldman @dgozman @nadavkaner @mxschmitt