[BUG] waitForSelector doesn't throw

[VincentDondain]

Context:

• Playwright Version: 1.7.0
• Operating System: macOS
• Node.js version: 11.1
• Browser: Chromium

Code Snippet

try {
    await page.waitForSelector('text="Personal codespaces"');
} catch {
    console.log("catch")
}

Describe the bug

Hi,

I'm expecting the code above to throw (according to the documentation) if it cannot find the selector (after it times out).

However with playwright 1.7.0 I am not entering the catch.

Am I doing something wrong?

Thanks

[VincentDondain]

Nevermind this works as expected (: