Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NavigationView] Settings label not vertically aligned with settings icon #5076

Closed
marcelwgn opened this issue May 22, 2021 · 3 comments · Fixed by #5187
Closed

[NavigationView] Settings label not vertically aligned with settings icon #5076

marcelwgn opened this issue May 22, 2021 · 3 comments · Fixed by #5187
Labels
area-NavigationView NavView control no-issue-activity team-Controls Issue for the Controls team working on it

Comments

@marcelwgn
Copy link
Collaborator

Currently, the settings element text and icon are not vertically aligned, instead the text sits a bit lower:
Screenshot of unaligned settings text and icon

However it would probably be better if they are vertically aligned with each other:
Mockup of aligned settings text and icon

@mdtauk FYI
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label May 22, 2021
@mdtauk
Copy link
Contributor

mdtauk commented May 22, 2021

How does it look when using the new Segoe UI Variable font?

What about with other typefaces should it get swapped out with Roboto, Google Sans Text, SF, or any of the localisation fonts?

Is there a typographic alignment setting that would align it as the font changes?

Also how does it look when using the new Fluent UI System Icons' Settings icon?

@ranjeshj
Copy link
Contributor

@karenbtlai as FYI.

@ranjeshj ranjeshj added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels May 24, 2021
@marcelwgn marcelwgn mentioned this issue Jun 13, 2021
Merged
@ghost ghost added the working on it label Jun 13, 2021
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-NavigationView NavView control no-issue-activity team-Controls Issue for the Controls team working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NavigationView] Fix centering of NVI labels a bit using bottom padding marcelwgn/microsoft-ui-xaml
3 participants
@mdtauk @marcelwgn @ranjeshj