Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case fails because of localized account names #202

Closed
mversiotech opened this issue Apr 8, 2021 · 2 comments · Fixed by #228
Closed

Test case fails because of localized account names #202

mversiotech opened this issue Apr 8, 2021 · 2 comments · Fixed by #228

Comments

@mversiotech
Copy link
Contributor

TestLookupValidSid tries to lookup the SID for the group "Everyone". Since Windows uses localized names for built-in accounts, this test case will fail when executed under non-English versions of Windows.
@yusufpapurcu
Copy link

No it does not fail in Turkish Windows 10 Home. I don't know exactly why but I think function localize group name in api side.

@mversiotech
Copy link
Contributor Author

No it does not fail in Turkish Windows 10 Home. I don't know exactly why but I think function localize group name in api side.

I think not every localized version of Windows uses translated account names. If the group with SID "S-1-1-0" is named "Everyone", the test will work, otherwise it won't. On my German system for example, the account is named "Jeder" which is why the test fails.

@mversiotech mversiotech mentioned this issue Dec 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lookup of account names by SID
2 participants
@yusufpapurcu @mversiotech