Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add links to documentation header #3666

Closed
EisenbergEffect opened this issue Aug 10, 2020 · 8 comments · Fixed by #3684
Closed

feat: add links to documentation header #3666

EisenbergEffect opened this issue Aug 10, 2020 · 8 comments · Fixed by #3684
Labels
area:site Pertains to work on the web site. closed:done Work is finished feature A new feature
Milestone

Comments

@EisenbergEffect
Copy link
Contributor

The documentation should have the same three links as the home page, except replacing the "Documentation" link with a "Home" link.

@EisenbergEffect EisenbergEffect added feature A new feature area:site Pertains to work on the web site. labels Aug 10, 2020
@EisenbergEffect EisenbergEffect added status:needs-investigation Needs additional investigation status:planned Work is planned and removed status:planned Work is planned labels Aug 10, 2020
@EisenbergEffect EisenbergEffect added this to the Release 06 milestone Aug 11, 2020
@EisenbergEffect
Copy link
Contributor Author

@adityar-r
Copy link
Contributor

Thanks a lot.

@adityar-r
Copy link
Contributor

fast_result
Is this the expected result?

@adityar-r
Copy link
Contributor

adityar-r commented Aug 11, 2020

fast_result
Is this the expected result?
fast_result2

Sorry, I missed the change in positions.

@chrisdholt
Copy link
Member

@bw-space, I think for the most part that looks good. @EisenbergEffect if the FAST logo takes you to the homepage, do we need a link for "Home"? If we do need "Home" I think the secondary position looks good (updated while I was typing 😄 ).

@chrisdholt
Copy link
Member

@bw-space let's go ahead and create a PR with it how it is - @EisenbergEffect is ahead of me by about 3hrs so I anticipate in the AM we'll get resolution for whether we need the home link or not (given that the logo goes to the homepage).

@adityar-r
Copy link
Contributor

ok cool, I am working on it.

@EisenbergEffect
Copy link
Contributor Author

@chrisdholt Per a convo I had with @Falkicon he wanted to have the Home link as well. There was some concern that the logo might not be obvious enough on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:site Pertains to work on the web site. closed:done Work is finished feature A new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants