-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divider line thickness not consistent at 150% scale #2231
Comments
Thanks @adkaufm - Ideally I'd love this to get fixed on the rendering side of things, but that can obviously be complex. Do you know if this repro's at all in non-chromium browsers? My immediate thought is in scenarios where this is important a user can always pass the style in as an unhandled prop which would cause it to inline to the DOM and take precedence. Pinging other @microsoft/fast-dna-collaborators for their thoughts on the above as well. |
Right - I added the fix with an unhandled prop every time we use Divider. And I agree that a fix on the renderer would be ideal here. I just thought to raise the issue here given that Chrome is such a big share of the market. And keep in mind many devices are automatically at 150% scale (surface products for example), so it will repro a lot. |
For sure, I think this is a valid scenario and worth the conversation. |
@adkaufm there could be an interesting experiment here. What would happen to all FAST components if we set the design system system value for certain things to a value derived from @bheston for awareness |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
closed with #3517 |
The thickness of the Divider component is not consistent when the page is scaled to 150%.
I would expect that the thickness would always be exactly one pixel.
This issue is observed on Windows in both Chromium-Edge and retail Chrome. It seems to be a renderer bug, but I found a fix that works. Setting the border width to 1/window.devicePixelRatio makes the line always 1 pixel. However this has to be done at render time because devicePixelRatio might change.
Overall, I'm not sure it makes sense to fix this in the fast component. Please let me know what you guys think. Maybe providing a utility function, or adding a prop like adjustForScaleFactor or something.
The text was updated successfully, but these errors were encountered: