From 9b14c5f54273e9db7a05fa838b561af8fb4c812b Mon Sep 17 00:00:00 2001
From: Brian Lagunas <brianlagunas@users.noreply.github.com>
Date: Wed, 12 Apr 2023 16:31:34 -0600
Subject: [PATCH 1/5] removed unneeded references

---
 .../Microsoft.Xaml.Behaviors.csproj           | 20 -------------------
 src/Microsoft.Xaml.Behaviors/packages.config  |  5 -----
 2 files changed, 25 deletions(-)
 delete mode 100644 src/Microsoft.Xaml.Behaviors/packages.config

diff --git a/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj b/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
index 4eb3d52..e12d249 100644
--- a/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
+++ b/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
@@ -30,22 +30,6 @@
   
   <Import Project="..\Microsoft.Xaml.Behaviors.Signing.targets" />
 
-  <ItemGroup Condition="'$(TargetFramework)'=='net462'">
-    <Reference Include="System" />
-    <Reference Include="System.Core" />
-    <Reference Include="System.Xaml" />
-    <Reference Include="System.XML" />
-    <Reference Include="WindowsBase">
-      <Private>False</Private>
-    </Reference>
-    <Reference Include="PresentationCore">
-      <Private>False</Private>
-    </Reference>
-    <Reference Include="PresentationFramework">
-      <Private>False</Private>
-    </Reference>
-  </ItemGroup>
-
   <ItemGroup>
     <Compile Update="ExceptionStringTable.Designer.cs">
       <SubType>Code</SubType>
@@ -73,10 +57,6 @@
     <PackageReference Include="Nerdbank.GitVersioning" Version="3.3.37" PrivateAssets="All" />
   </ItemGroup>
 
-  <ItemGroup>
-    <None Include="packages.config" />
-  </ItemGroup>
-
   <ItemGroup>
     <!-- Install.ps1 is for .NET Framework projects (not .NET Core).
     The script removes the reference to the .Design.dll in the referencing project.
diff --git a/src/Microsoft.Xaml.Behaviors/packages.config b/src/Microsoft.Xaml.Behaviors/packages.config
deleted file mode 100644
index bc99dd3..0000000
--- a/src/Microsoft.Xaml.Behaviors/packages.config
+++ /dev/null
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<packages>
-  <package id="MicroBuild.Core" version="0.3.0" targetFramework="net40" developmentDependency="true" />
-  <package id="NuGet.Build.Tasks.Pack" version="4.8.0" targetFramework="net40" />
-</packages>
\ No newline at end of file

From 0dca6a176ad5c6ff46abe25260f5a246a5f77ad2 Mon Sep 17 00:00:00 2001
From: Brian Lagunas <brianlagunas@users.noreply.github.com>
Date: Wed, 12 Apr 2023 16:48:59 -0600
Subject: [PATCH 2/5] added 1591 to no warn and cleaned up other build warnings

---
 .../Core/ExtendedVisualStateManager.cs                | 10 ++++++++--
 .../Microsoft.Xaml.Behaviors.csproj                   | 11 ++++++++++-
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/src/Microsoft.Xaml.Behaviors/Core/ExtendedVisualStateManager.cs b/src/Microsoft.Xaml.Behaviors/Core/ExtendedVisualStateManager.cs
index cbb912b..80b394a 100644
--- a/src/Microsoft.Xaml.Behaviors/Core/ExtendedVisualStateManager.cs
+++ b/src/Microsoft.Xaml.Behaviors/Core/ExtendedVisualStateManager.cs
@@ -779,6 +779,7 @@ private static Storyboard ExtractLayoutStoryboard(VisualState state)
         /// Subsequent code will check these rectangles both before and after the layout change.
         /// </summary>
         /// <param name="control">The control whose layout is changing state.</param>
+        /// <param name="templateRoot">The template root.</param>
         /// <param name="layoutStoryboard">The storyboard containing the layout changes.</param>
         /// <param name="originalValueRecords">Any previous values from previous state navigations that might be reverted.</param>
         /// <param name="movingElements">The set of elements currently in motion, if there is a state change transition ongoing.</param>
@@ -1014,8 +1015,10 @@ internal static Rect GetLayoutRect(FrameworkElement element)
         /// Get the opacities of elements at the time of the state change, instead of visibilities, because the state change may be in process and the current value is the most important.
         /// </summary>
         /// <param name="control">The control whose state is changing.</param>
+        /// <param name="templateRoot">The template root.</param>
         /// <param name="layoutStoryboard">The storyboard with the layout properties.</param>
         /// <param name="originalValueRecords">The set of original values.</param>
+        /// <param name="movingElements">The elements currently in motion</param>
         /// <returns></returns>
         private static Dictionary<FrameworkElement, double> GetOldOpacities(FrameworkElement control, FrameworkElement templateRoot, Storyboard layoutStoryboard, List<OriginalLayoutValueRecord> originalValueRecords, List<FrameworkElement> movingElements)
         {
@@ -1078,6 +1081,7 @@ private static Dictionary<FrameworkElement, double> GetOldOpacities(FrameworkEle
         /// All values that are overwritten will be stored in the collection of OriginalValueRecords so that they can be replaced later.
         /// </summary>
         /// <param name="control">The control whose state is changing.</param>
+        /// <param name="templateRoot">The template root.</param>
         /// <param name="layoutStoryboard">The Storyboard holding the layout properties.</param>
         /// <param name="originalValueRecords">The store of original values.</param>
         [SuppressMessage("Microsoft.Maintainability", "CA1506:AvoidExcessiveClassCoupling", Justification = "This is done in a single pass for performance reasons.")]
@@ -1186,6 +1190,8 @@ private static object GetValueFromTimeline(Timeline timeline, out bool gotValue)
         /// they do not affect their sibling elements.
         /// </summary>
         /// <param name="movingElements">The set of elements that will be moving.</param>
+        /// <param name="oldRects">The old Rect.</param>
+        /// <param name="newRects">The new Rect.</param>
         private static void WrapMovingElementsInCanvases(List<FrameworkElement> movingElements, Dictionary<FrameworkElement, Rect> oldRects, Dictionary<FrameworkElement, Rect> newRects)
         {
             foreach (FrameworkElement movedElement in movingElements)
@@ -1286,6 +1292,7 @@ private static void UnwrapMovingElementsFromCanvases(List<FrameworkElement> movi
         /// </summary>
         /// <param name="source">The source of the layout properties.</param>
         /// <param name="target">The destination of the layout properties.</param>
+        /// <param name="restoring">A flag to indicate if a restore is occuring.</param>
         private static void CopyLayoutProperties(FrameworkElement source, FrameworkElement target, bool restoring)
         {
             WrapperCanvas parentCanvas = (restoring ? source : target) as WrapperCanvas;
@@ -1339,8 +1346,7 @@ private static void CopyLayoutProperties(FrameworkElement source, FrameworkEleme
         /// <summary>
         /// Create the actual Storyboard that will be used to animate the transition. Use all previously calculated results.
         /// </summary>
-        /// <param name="duration">The duration of the animation.</param>
-        /// <param name="ease">The easing function to be used in the animation.</param>
+        /// <param name="transition">The transition.</param>
         /// <param name="movingElements">The set of elements that will be moving.</param>
         /// <param name="oldOpacities">The old opacities of the elements whose visibility properties are changing.</param>
         /// <returns>The Storyboard.</returns>
diff --git a/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj b/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
index e12d249..cdb885a 100644
--- a/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
+++ b/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
@@ -24,8 +24,17 @@
     <UseWPF>true</UseWPF>
     <GenerateNuspecDependsOn>$(GenerateNuspecDependsOn);TimestampNugetPackage</GenerateNuspecDependsOn>
   </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net462|AnyCPU'">
+    <NoWarn>1701;1702;1591</NoWarn>
+  </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net462|AnyCPU'">
-    <NoWarn>1701;1702;</NoWarn>
+    <NoWarn>1701;1702;1591</NoWarn>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net6.0-windows|AnyCPU'">
+    <NoWarn>1701;1702;1591</NoWarn>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net6.0-windows|AnyCPU'">
+    <NoWarn>1701;1702;1591</NoWarn>
   </PropertyGroup>
   
   <Import Project="..\Microsoft.Xaml.Behaviors.Signing.targets" />

From 071c73b9bdac2ed4446da39595d6963e863bdc30 Mon Sep 17 00:00:00 2001
From: Brian Lagunas <brianlagunas@users.noreply.github.com>
Date: Wed, 12 Apr 2023 17:05:26 -0600
Subject: [PATCH 3/5] fixed test build warnings

---
 Test/UnitTests/BehaviorUtilities.cs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Test/UnitTests/BehaviorUtilities.cs b/Test/UnitTests/BehaviorUtilities.cs
index 2bb00d8..3202940 100644
--- a/Test/UnitTests/BehaviorUtilities.cs
+++ b/Test/UnitTests/BehaviorUtilities.cs
@@ -168,8 +168,10 @@ public override void Fail(string message)
         }
         #endregion
 
+#if !NETCOREAPP
         private TraceListener[] storedListeners;
-        private DebugTraceListener debugTraceListener;
+#endif
+        private DebugTraceListener debugTraceListener = new DebugTraceListener();
 
         public List<string> Messages
         {
@@ -205,4 +207,4 @@ public void Dispose()
 
 #endregion
     }
-}
\ No newline at end of file
+}

From 937b275e7c3bbd965944a1807c9117629f871c92 Mon Sep 17 00:00:00 2001
From: Brian Lagunas <brianlagunas@users.noreply.github.com>
Date: Wed, 12 Apr 2023 17:17:27 -0600
Subject: [PATCH 4/5] removed conditional from nowarn element

---
 .../Microsoft.Xaml.Behaviors.csproj                   | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj b/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
index cdb885a..25f3364 100644
--- a/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
+++ b/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
@@ -24,16 +24,7 @@
     <UseWPF>true</UseWPF>
     <GenerateNuspecDependsOn>$(GenerateNuspecDependsOn);TimestampNugetPackage</GenerateNuspecDependsOn>
   </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net462|AnyCPU'">
-    <NoWarn>1701;1702;1591</NoWarn>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net462|AnyCPU'">
-    <NoWarn>1701;1702;1591</NoWarn>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net6.0-windows|AnyCPU'">
-    <NoWarn>1701;1702;1591</NoWarn>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net6.0-windows|AnyCPU'">
+  <PropertyGroup>
     <NoWarn>1701;1702;1591</NoWarn>
   </PropertyGroup>
   

From 5b5fcfe0d46a16603137693dbb90aa3f3e670819 Mon Sep 17 00:00:00 2001
From: Brian Lagunas <brianlagunas@users.noreply.github.com>
Date: Wed, 12 Apr 2023 17:20:14 -0600
Subject: [PATCH 5/5] moved nowarn to root property group

---
 src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj b/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
index 25f3364..2197520 100644
--- a/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
+++ b/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj
@@ -23,8 +23,6 @@
     <DefineConstants>WPF;$(DefineConstants)</DefineConstants>
     <UseWPF>true</UseWPF>
     <GenerateNuspecDependsOn>$(GenerateNuspecDependsOn);TimestampNugetPackage</GenerateNuspecDependsOn>
-  </PropertyGroup>
-  <PropertyGroup>
     <NoWarn>1701;1702;1591</NoWarn>
   </PropertyGroup>