-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: 'rest' index signatures and the 'error' type #7765
Comments
I'm rethinking my use of the "bottom" type here [Edit: modified the text to use Wikipedia says the "bottom" type may be used:
Or
So I guess the second is closer to what I meant, though this may not be the most common meaning. If anyone has a better suggestion to a type that "cannot be assigned to or from anything" (this includes to or from Edit: still thinking about whether one |
Another problem with string literals in index signature keys (and "normal" properties as well), is that is not possible to define: interface Example {
[letter: "a" | "b" | "c"]: number;
[key: string]: boolean; // <-- Error
} That wouldn't work, as the second index signature conflicts with the first one. As a possible solution, what if there were specialized 'rest' signatures that only included the 'rest' of a particular key type, like: interface Example {
[letter: "a" | "b" | "c"]: number;
[key: ...string]: boolean;
} This can be useful with regular properties as well since even today this produces an error: interface Example {
a: number; // <-- Error, not assignable to index signature
b: number; // <-- Error, not assignable to index signature
c: number; // <-- Error, not assignable to index signature
[key: string]: boolean;
} (The same would happen if all properties were optional) So a typed 'rest' index signature would allow specifying all other string keys: interface Example {
a: number; // OK
b: number; // OK
c: number; // OK
[key: ...string]: boolean;
} |
Wait, what? I was utterly surprised when I found out that I can't do this: export interface VNodeStyle {
delayed: { [prop: string]: string }
[prop: string]: string
} because I would get
|
So, whatever. Fix it please. Yet, how would I get around it? |
You can try: export type VNodeStyle = { delayed: { [prop: string]: string } } & { [prop: string]: string }; |
@SlurpTheo it's the same as one interface. The only difference is that interface shows the error right away but alias shows the error when you try to create a variable const test: VNodeStyle = {
delayed: { hello: "World" },
rest: "Hi",
};
I was also surprised it doesn't work. I need to create an interface with props that a component receives from redux-form interface IFieldNames {
field1: string;
field2: string;
}
interface IMyComponentProps {
customProp1: string;
customProp2: boolean;
customPropFieldNames: IFieldNames;
[field: ...string]: { input: {...}; meta: {...} };
} const fieldNamesProvidedByUser: IFieldNames = ...;
<Fields
names={Object.values(fieldNamesProvidedByUser)}
component={MyComponent}
customProp1="stringProp"
customProp2={true}
customPropFieldNames={fieldNamesProvidedByUser}
/> then in component I do const { customProp1, customProp2, customPropFieldNames, ...props } = this.props;
const field1Props = props[customPropFieldNames.field1]; // {input: {...}, meta: {...}}
const field2Props = props[customPropFieldNames.field2]; |
Is this feature ever coming? |
[This idea is still in a relatively early stage of development, but I thought it may be of worth to someone or even for the TS team itself. Feel free to share your thoughts]
Having literal types, or unions of them, in index signatures is an idea that was brought to discussion lately (see #5683, #7656 and more general discussion in #7660):
However the conventional semantics of index signatures would imply that the type checking here would be very weak, unless
noImplicitAny
is enabled:What if it there was a way to specify the type of all the 'remaining' access keys to the interface with a special "rest" index signature (notated as
[key: ...any]: T
) that would set a particular type for everything other than that was specified in the interface?This may also be useful to avoid unwanted type errors when
noImplicitAny
is enabled:And what if it would be set to some sort of an 'error' type? I.e. a type that would not be assignable to or from anything? (perhaps except itself, still thinking about it..).
With the
<Error>
type, any assignment to or from a key that is not"a"
,"b"
or"c"
would yield an error, as it cannot be assigned to or from anything:Or even:
Open questions:
[key: any...]: <Error>
convert any interface to a "strict" interface? (i.e. one that cannot be assigned from a 'wider' type containing more properties). And if it would, would that be seen as desirable or useful?Edits: expanded and corrected examples to the actual behavior with
noImplicitAny
enabled.Edits: converted from 'bottom' to
<Error>
as I seemed to have used a less common interpretation of the 'bottom' typeEdits (13 May 2016): changed
[...]
to[key: ...any]
for better consistency with the current syntax.The text was updated successfully, but these errors were encountered: