TypeScript transformers don't bind imports added during a transformation

[itsdouges]

TypeScript Version: 3.7.x-dev.201xxxxx

Search Terms:

Code

https://github.com/atlassian-labs/compiled-css-in-js

Expected behavior:

• Usage of imports get renamed when targetting CJS modules
• Imports do not get removed when they are used

Actual behavior:

• Usage of imports do not get renamed - I need to use this hack to make it work which is very brittle https://github.com/atlassian-labs/compiled-css-in-js/blob/master/packages/ts-transform/src/constants.tsx#L31
• Usage of imports get removed - this PR shows it happening [Blocked] Use React namespace import instead of default import atlassian-labs/compiled#164 description has how to run the test

Playground Link:

Related Issues:

• Implement React's jsx/jsxs Factory Changes #34547
• Plugin Support for Custom Transformers #14419 (comment)

I have no idea how the auto react import will work without this being fixed.

[rbuckton]

There are some features of the compiler you can employ to produce the same generated name for the react import. The name react_1 is a special GeneratedIdentifier node and isn't value isn't known until after transforms are run and emit occurs. You can create a GeneratedIdentifier for a specific node using getGeneratedNameForNode, which will always generate the same name for the same node. The CommonJS transformer uses that behavior for the module name for a default import:

TypeScript/src/compiler/transformers/module/module.ts

Lines 806 to 817 in 9458f8a

	// import d from "mod";
	// import { x, y } from "mod";
	// import d, { x, y } from "mod";
	// import d, * as n from "mod";
	variables.push(
	factory.createVariableDeclaration(
	factory.getGeneratedNameForNode(node),
	/*exclamationToken*/ undefined,
	/*type*/ undefined,
	getHelperExpressionForImport(node, createRequireCall(node))
	)
	);

You can use the same behavior to get the generated name for the react import node in your own code, given the current transformation's input SourceFile:

1. Get the original parse-tree SourceFile using getParseTreeNode(file). This will give you the SourceFile as originally parsed before any transformations have been applied.
2. Search statements of the original SourceFile to find an ImportDeclaration for "react".
3. Use getGeneratedNameForNode(node) on the ImportDeclaration.

This will give you a GeneratedIdentifier corresponding to the ImportDeclaration that will produce the same identifier value that the CommonJS transform uses.

[rbuckton]

To clarify, this isn't a bug in the compiler, but rather is due to the nature of how the transforms work. Binding and type-checking occur before any transformations are evaluated and transformed nodes are never re-bound.