Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[* NumberWithUnit] Unit should be normalized and not language dependent #513

Open
RomainWilbert opened this issue May 2, 2018 · 2 comments

Comments

@RomainWilbert
Copy link

using french language, "20 kilometres" resolves to [ value = 20, unit = "Kilomètre" ]
using english language, "20 kilometers" resolves to [ value = 20, unit = "Kilometer" ]

Shouldn't the units be normalized using international/imperial system of units (km, mi, Euro, USD...) or at least have same constants for all languages ? This would be easier for conversions and data process.

@tellarin
Copy link
Collaborator

tellarin commented May 3, 2018

Hi @RomainWilbert,

thanks for the feedback. Users had previously requested to have the "localized unit name" in the response.

But we agree that a standard/normalized unit name is very useful in many scenarios and we plan to also have a separate field for the SI unit (or equivalent).

Currency is the first unit to have it. English Currency already has isoCodes for the units (USD, EUR, etc).
Other languages are coming soon, followed by other units.

@tellarin
Copy link
Collaborator

tellarin commented May 3, 2018

Any contributions are also greatly welcome! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants