Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivvi st_dacs_zero too fast #508

Closed
damazter opened this issue Mar 3, 2017 · 1 comment
Closed

Ivvi st_dacs_zero too fast #508

damazter opened this issue Mar 3, 2017 · 1 comment
Labels

Comments

@damazter
Copy link
Contributor

damazter commented Mar 3, 2017

@AdriaanRol

Steps to reproduce

  1. use ivvi.set_dacs_zero

Expected behaviour

All dacs should sweep to zero, no faster than is allowed by their parameter settings
dac_step and dac_delay

Actual behaviour

instead the function _set_dac is used which does not listen to dac_step and dac_delay

###Proposed Solution
change set_dacs_zero to (untested):

for i in range(self._numdacs):
    self.parameters['dac{}'.format(i+1)].set(0)

System

operating system
Windows 7

branch derived from
qcodes branch
master
qcodes commit
latest merged qcodes master commit:
c67ced6

@AdriaanRol
Copy link
Contributor

@damazter I agree that this is unintended behaviour, and ofcourse I aprove of the proposed solution 👍 Thanks for finding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants