Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver test. #475

Open
giulioungaretti opened this issue Feb 3, 2017 · 5 comments
Open

Driver test. #475

giulioungaretti opened this issue Feb 3, 2017 · 5 comments
Labels

Comments

@giulioungaretti
Copy link
Contributor

We need some solution (that should have been baked into the base class to begin with) to make sure the drivers are actually valid python.

@jenshnielsen
Copy link
Collaborator

I.e #474
and
in #459 the default values could not validate

@giulioungaretti
Copy link
Contributor Author

@jenshnielsen I am thinking about having a mock, that simply replaces base, and tests if all the instruments at least can be instantiated.

@jenshnielsen
Copy link
Collaborator

Yes agreed, have been doing that manually when testing drivers for instruments that I don't have easy access to. Above is just some examples of why we need it

@jenshnielsen jenshnielsen changed the title Dirver test. Driver test. Aug 11, 2017
@sohailc
Copy link
Member

sohailc commented Aug 16, 2017

Making a mock instrument server which receives messages and sends reply's on specified ports on localhost is I think the best option for making being able to run and debug instrument drivers, at least for IP instruments. In this way we can leave the driver unmodified, that is, the driver being tested is exactly the same as the driver that will actually be used. I have made mock instrument server in my PR (#700), but maybe it is a good idea to open a seperate PR specifically for this problem.

@WilliamHPNielsen
Copy link
Contributor

I guess this was dealt with by #859. At least for VISA instruments there is now a standard way of doing this.

@astafan8 astafan8 removed the p1 label Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants