-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerToys Run Shell integration; default terminal profile is not used #28876
Comments
This comment has been minimized.
This comment has been minimized.
This is caused by the following code: https://github.com/microsoft/PowerToys/blob/main/src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Main.cs#L223-L230 |
From what I have tested using the default profile is impossible because of two problems (keeping window open setting and microsoft/terminal#16062) But I can rework the behavior that the user selects the shell (e.g. PowerShell 7) and has a checkbox to run Shells (cmd, ps 5, pwsh 7) in WT. Does that sounds good to you? cc: @jaimecbernardo |
@htcfreek, thanks for the quick response. Your suggestion sounds like a good idea. However, maybe this is something you could use to make this work; https://learn.microsoft.com/nl-be/windows/terminal/command-line-arguments?tabs=powershell#open-a-new-profile-instance |
Two problems:
|
I did not in fact needed v1.19 to be able to use However I do not know if why it does not support "keep window open" and if its something we could change. |
The main question is how we can implement it in a simple and user friendly way. (I plan to implement #28889 later if WT 1.19 is stable, if I remove an dropdown item settings will crash and the "keep shell open" setting isn't working in all WT scenarios.) |
@htcfreek Great! Then we can only wait until they release v1.19. Maybe you could make a dropdown allowing the user to choose between the default profile (by using |
This fix/feature is included in the new 0.75.0 release of PowerToys. |
Microsoft PowerToys version
0.74.0
Installation method
WinGet, Chocolatey
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
Launch PowerToys Run and enter a Shell command like
ping github.com
while the Shell integration is set to use windows terminal.✔️ Expected Behavior
When a command like
ping github.com
is launche₫ with PowerToys Run, it should open a new instance of Windows Terminal with the default profile. Or there should be a possibility to set the profile you want to use.❌ Actual Behavior
It opened a terminal instance with the legacy powershell 5.
Other Software
Windows Terminal version: 1.18.2681.0
The text was updated successfully, but these errors were encountered: