You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IContainerRuntime.createRootDataStore and IContainerRuntimeBase._createDataStoreWithProps with isRoot set to true. The latter has already been deprecated (0.16 Issue #1537, #3631)
Context
The APIs are vulnerable to name conflicts, which lead to invalid documents. See #6465
Approach
The replacement API has two parts:
Creating a regular datastore using the IContainerRuntimeBase.createDataStore(pkg: string | string[]): Promise<IDataStore> function
Aliasing the datastore by using the IDataStore.trySetAlias(alias: string): Promise<AliasResult> function and specifying a string value to serve as the alias to which the datastore needs to be bound. If successful, "Success" will be returned, and a call to getRootDataStore with the alias as parameter will return the same datastore.
Dependencies
Currently, the API is used across the Fluid examples and in some Bohemia use-cases.
Compatibility Concerns
The migration can be started after runtime version >= 0.56.0 reaches full/reasonable saturation.
Deprecated API
IContainerRuntime.createRootDataStore
andIContainerRuntimeBase._createDataStoreWithProps
withisRoot
set totrue
. The latter has already been deprecated (0.16 Issue #1537, #3631
)Context
The APIs are vulnerable to name conflicts, which lead to invalid documents. See #6465
Approach
The replacement API has two parts:
IContainerRuntimeBase.createDataStore(pkg: string | string[]): Promise<IDataStore>
functionIDataStore.trySetAlias(alias: string): Promise<AliasResult>
function and specifying a string value to serve as the alias to which the datastore needs to be bound. If successful, "Success" will be returned, and a call togetRootDataStore
with the alias as parameter will return the same datastore.Dependencies
Currently, the API is used across the Fluid examples and in some Bohemia use-cases.
Compatibility Concerns
The migration can be started after runtime version >=
0.56.0
reaches full/reasonable saturation.Phases
_createDataStoreWithProps
to measure who/what is calling it withisRoot
set totrue
Identify when the legacy_createDataStoreWithProps
API is used to create root datastores #9796createRootDataStore
as deprecated, migrate examples #9829createRootDataStore
as deprecated, migrate examples #9829createRootDataStore
API #9831createRootDataStore
#9832Expected Timeline
TBD
Open Questions
TBD
The text was updated successfully, but these errors were encountered: