microros_component/extra_packages support #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogs9
requested changes
Jun 15, 2022
microros_static_library/library_generation/library_generation.sh
Outdated
Show resolved
Hide resolved
microros_static_library/library_generation/library_generation.sh
Outdated
Show resolved
Hide resolved
microros_static_library_ide/library_generation/library_generation.sh
Outdated
Show resolved
Hide resolved
pablogs9
approved these changes
Jun 15, 2022
|
@mergify backport galactic humble main |
🟠 Waiting for conditions to match
|
Acuadros95
approved these changes
Jun 15, 2022
✅ Backports have been created
|
pablogs9
pushed a commit
that referenced
this pull request
Jun 15, 2022
* added microros_component/extra_packages support * added microros_component/extra_packages_support * copy only if usr pkgs exist * changes requested by @pablogs9 (cherry picked from commit 796035d) Co-authored-by: Harsh Davda <[email protected]>
pablogs9
pushed a commit
that referenced
this pull request
Jun 15, 2022
* added microros_component/extra_packages support * added microros_component/extra_packages_support * copy only if usr pkgs exist * changes requested by @pablogs9 (cherry picked from commit 796035d) Co-authored-by: Harsh Davda <[email protected]>
pablogs9
pushed a commit
that referenced
this pull request
Jun 15, 2022
* added microros_component/extra_packages support * added microros_component/extra_packages_support * copy only if usr pkgs exist * changes requested by @pablogs9 (cherry picked from commit 796035d) Co-authored-by: Harsh Davda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenience and maintaining modularity, it is better to keep custom packages outside the micro_ros_stm32cubemx_utils. This has been specified in the Readme, but as I looked into the code wasn't able to find anywhere implemented.