Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple addresses separated by comma #156

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Allow multiple addresses separated by comma #156

merged 2 commits into from
Aug 7, 2020

Conversation

georf
Copy link
Contributor

@georf georf commented Jul 2, 2020

In some cases you want to check multiple email fields:

class Invoice
  validates :receivers, 'valid_email_2/email': { mx: true, disposable: true, multiple: true }
end

Invoice.new(receivers: "[email protected],[email protected]")

Each other option will check for each address.

In some cases you want to check multiple email fields:

```
class Invoice
  validates :receivers, 'valid_email_2/email': { mx: true, disposable: true, multiple: true }
end

Invoice.new(receivers: "[email protected],[email protected]")
```

Each other option will check for each address.
@georf
Copy link
Contributor Author

georf commented Aug 4, 2020

Do you don't want do merge it or don't you have time for the moment? I want to use this gem, but I need the possibility of multiple email addresses.

Copy link
Owner

@micke micke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response and thanks for the PR, i'm seeing one potential issue with this new functionality!

lib/valid_email2/email_validator.rb Outdated Show resolved Hide resolved
Copy link
Owner

@micke micke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Thanks!

@micke micke merged commit 6409d1a into micke:master Aug 7, 2020
@micke
Copy link
Owner

micke commented Aug 7, 2020

@georf Thank you so much for your contributions! I've pushed v3.3.0 to rubygems, if you would like to give them a try!

@georf georf deleted the allow_multiple_addresses branch August 10, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants